From: Nicholas Mc Guire <hofrat@osadl.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Luis de Bethencourt <luis@debethencourt.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH] mmc: moxart: fix wait_for_completion_interruptible_timeout return variable type
Date: Sun, 24 Jul 2016 18:32:17 +0200 [thread overview]
Message-ID: <1469377937-14360-1-git-send-email-hofrat@osadl.org> (raw)
wait_for_completion_timeout_interruptible returns long not unsigned long
so dma_time, which is used exclusively here, is changed to long.
Fixes: 1b66e94e6b99 ("mmc: moxart: Add MOXA ART SD/MMC driver")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
API non-compliance was located by coccinelle
This is mostly cosmetic since dma_time is not actually used for anything
at present, however if it ever were, then a signal received would be
interpreted as a large remaining jiffies left, which would be wrong.
Compile tested with: moxart_defconfig + ARCH_MULTI_V4=y,
CONFIG_ARCH_MOXART=y, CONFIG_MMC_MOXART=y
Patch is against 4.7.0-rc7 (localversion-next -next-20160724)
drivers/mmc/host/moxart-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
index 79905ce..2e5c25f 100644
--- a/drivers/mmc/host/moxart-mmc.c
+++ b/drivers/mmc/host/moxart-mmc.c
@@ -257,7 +257,7 @@ static void moxart_dma_complete(void *param)
static void moxart_transfer_dma(struct mmc_data *data, struct moxart_host *host)
{
u32 len, dir_data, dir_slave;
- unsigned long dma_time;
+ long dma_time;
struct dma_async_tx_descriptor *desc = NULL;
struct dma_chan *dma_chan;
@@ -397,7 +397,7 @@ static void moxart_prepare_data(struct moxart_host *host)
static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct moxart_host *host = mmc_priv(mmc);
- unsigned long pio_time, flags;
+ long pio_time, flags;
u32 status;
spin_lock_irqsave(&host->lock, flags);
--
2.1.4
next reply other threads:[~2016-07-24 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 16:32 Nicholas Mc Guire [this message]
2016-07-25 8:29 ` Ulf Hansson
2016-07-25 13:20 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469377937-14360-1-git-send-email-hofrat@osadl.org \
--to=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®