From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbcGYHFm (ORCPT ); Mon, 25 Jul 2016 03:05:42 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33894 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbcGYHFf (ORCPT ); Mon, 25 Jul 2016 03:05:35 -0400 From: Wei Yongjun To: Alessandro Zummo , Alexandre Belloni Cc: Wei Yongjun , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH -next] rtc: asm9260: Fix missing spin_lock_init() Date: Mon, 25 Jul 2016 07:05:29 +0000 Message-Id: <1469430329-8737-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun --- drivers/rtc/rtc-asm9260.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c index 355fdb9..5ddcc91 100644 --- a/drivers/rtc/rtc-asm9260.c +++ b/drivers/rtc/rtc-asm9260.c @@ -267,6 +267,7 @@ static int asm9260_rtc_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; + spin_lock_init(&priv->lock); priv->dev = &pdev->dev; platform_set_drvdata(pdev, priv);