From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbcGYTUD (ORCPT ); Mon, 25 Jul 2016 15:20:03 -0400 Received: from www.osadl.org ([62.245.132.105]:34861 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbcGYTT7 (ORCPT ); Mon, 25 Jul 2016 15:19:59 -0400 From: Nicholas Mc Guire To: Greg Kroah-Hartman Cc: Wolfram Sang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] staging: ks7010: declare private functions static Date: Mon, 25 Jul 2016 21:22:27 +0200 Message-Id: <1469474547-15592-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Private functions in ks_hostif.c can be declared static. Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository") Signed-off-by: Nicholas Mc Guire --- Found by sparse The build of ks_hostif.o generated the following sparse warnings: CHECK drivers/staging/ks7010/ks_hostif.c drivers/staging/ks7010/ks_hostif.c:72:6: warning: symbol 'ks_wlan_hw_wakeup_task' was not declared. Should it be static? drivers/staging/ks7010/ks_hostif.c:1512:6: warning: symbol 'hostif_infrastructure_set2_request' was not declared. Should it be static? As both functions reported are private to this file it seems reasonable to declare them static. Compile tested with: x86_64_defconfig + CONFIG_STAGING=y CONFIG_MMC=m, CONFIG_KS7010=m Patch is against 4.7-rc7 (localversion-next -next-20160725) drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index a8822fe..71b6ba2 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -69,7 +69,7 @@ inline u32 get_DWORD(struct ks_wlan_private *priv) return data; } -void ks_wlan_hw_wakeup_task(struct work_struct *work) +static void ks_wlan_hw_wakeup_task(struct work_struct *work) { struct ks_wlan_private *priv = container_of(work, struct ks_wlan_private, ks_wlan_wakeup_task); @@ -1505,7 +1505,7 @@ void hostif_infrastructure_set_request(struct ks_wlan_private *priv) ks_wlan_hw_tx(priv, pp, hif_align_size(sizeof(*pp)), NULL, NULL, NULL); } -void hostif_infrastructure_set2_request(struct ks_wlan_private *priv) +static void hostif_infrastructure_set2_request(struct ks_wlan_private *priv) { struct hostif_infrastructure_set2_request_t *pp; uint16_t capability; -- 2.1.4