From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759276AbcG1CJd (ORCPT ); Wed, 27 Jul 2016 22:09:33 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36249 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758866AbcG1CJ0 (ORCPT ); Wed, 27 Jul 2016 22:09:26 -0400 From: Wei Yongjun To: Liviu Dudau , Brian Starkey , Mali DP Maintainers , David Airlie Cc: Wei Yongjun , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Date: Thu, 28 Jul 2016 02:09:13 +0000 Message-Id: <1469671753-12961-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TMASE-Version: CloudMessageScanner-0.0.0000-7.5.1021-22478.000 X-TMASE-Result: 10--6.452500-10.000000 X-TMASE-MatchedRID: dkXzegJ39QA4tGBQPT0ZoUhEDfw/93Bu+uIuZYGsMgRUjspoiX02Fwku iFJsQqOR5BvGbXImZuj1VmTZnVKT+JCoy9iDotiwFYJUGv4DL3zEoDEGChh7CWxZRBWPMUZWo8W MkQWv6iV95l0nVeyiuETkGP72Yfdk0C1sQRfQzEHEQdG7H66TyMdRT5TQAJnA3VrxtNgwsZP35A ELJ+YnDz0rMwlAg2Ps33bPJyI8CqieqD9WtJkSIw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the DRM_ERROR call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/arm/malidp_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 4e61ea5..1160322 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); hwdev->regs = devm_ioremap_resource(dev, res); - if (IS_ERR(hwdev->regs)) { - DRM_ERROR("Failed to map control registers area\n"); + if (IS_ERR(hwdev->regs)) return PTR_ERR(hwdev->regs); - } hwdev->pclk = devm_clk_get(dev, "pclk"); if (IS_ERR(hwdev->pclk))