From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759079AbcG1COm (ORCPT ); Wed, 27 Jul 2016 22:14:42 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33931 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756036AbcG1COi (ORCPT ); Wed, 27 Jul 2016 22:14:38 -0400 From: Wei Yongjun To: Liviu Dudau , Brian Starkey , Mali DP Maintainers , David Airlie Cc: Wei Yongjun , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Date: Thu, 28 Jul 2016 02:14:26 +0000 Message-Id: <1469672066-13401-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TMASE-Version: CloudMessageScanner-0.0.0000-7.5.1021-22478.000 X-TMASE-Result: 10--6.748000-10.000000 X-TMASE-MatchedRID: QMfkO3kOl484tGBQPT0ZoZdc7I2df+msc3ewuwbSaG5tw+n+iKWyyIZd Y0GqfUpiwV0qWXffyEVs8miomGtO4IqWws9vyPBrA9lly13c/gHt/okBLaEo+H5h6y4KCSJcKLW rCrDVHUni8zVgXoAltlwtzewu2M63c9hVI62Mplxq8/xv2Um1avoLR4+zsDTtw38dXReMtXe3Z3 ld2r6wsjmgpmL+xODQ5stUu2UGEsHb9jwqQonLylZca9RSYo/b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return error code -EINVAL from the error handling case instead of 0, as done elsewhere in this function. Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port instead of the endpoint') Signed-off-by: Wei Yongjun --- drivers/gpu/drm/arm/malidp_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 4e61ea5..44b24cb 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev) /* Set the CRTC's port so that the encoder component can find it */ ep = of_graph_get_next_endpoint(dev->of_node, NULL); - if (!ep) + if (!ep) { + ret = -EINVAL; goto port_fail; + } malidp->crtc.port = of_get_next_parent(ep); ret = component_bind_all(dev, drm);