From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759244AbcG1Ctl (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jul 2016 22:49:41 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:23894 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754062AbcG1Ctb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jul 2016 22:49:31 -0400
Message-ID: <1469674165.29230.1.camel@mtksdaap41>
Subject: Re: [PATCH v3] arm64: dts: mt8173: add mmsel clocks for 4K support
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
CC: Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
        "Pawel Moll" <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        James Liao <jamesjj.liao@mediatek.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        YH Huang <yh.huang@mediatek.com>, "CK Hu" <ck.hu@mediatek.com>,
        Yong Wu <yong.wu@mediatek.com>, Eddie Huang <eddie.huang@mediatek.com>,
        "dawei.chien@mediatek.com" <dawei.chien@mediatek.com>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Junzhi Zhao <junzhi.zhao@mediatek.com>
Date: Thu, 28 Jul 2016 10:49:25 +0800
In-Reply-To: <1469611964.2470.30.camel@pengutronix.de>
References: <1469607914-64831-1-git-send-email-bibby.hsieh@mediatek.com>
	 <1469611964.2470.30.camel@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Philipp,

Thanks for your comments.

On Wed, 2016-07-27 at 11:32 +0200, Philipp Zabel wrote:
> Am Mittwoch, den 27.07.2016, 16:25 +0800 schrieb Bibby Hsieh:
> > If MT8173 can support HDMI 4K resoultion, the
> > VENCPLL should be configured to 800MHZ.
> > We didn't set VENCPLL directly, we set the
> > mm_sel to 400MHz statically in the board device tree.
> 
> Maybe add a comment that the board .dts file should override the clock
> rate property with the higher VENCPLL frequency the board supports HDMI
> 4K resolution.
> 
Ok, I will add that.
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> > Changes since v2:
> >  - Align the clocks of dpi0 node.
> > 
> > Changes since v1:
> >  - Do not set the VENCPLL by clk_set_rate
> >    at display driver.
> >  - Configure the mm_sel to 400MHz statically
> >    in the board device tree.
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 78529e4..9c22204 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -690,7 +690,9 @@
> >  			compatible = "mediatek,mt8173-mmsys", "syscon";
> >  			reg = <0 0x14000000 0 0x1000>;
> >  			power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > +			clocks = <&topckgen CLK_TOP_MM_SEL>;
> >  			#clock-cells = <1>;
> > +			clock-frequency  = <400000000>;
> 
> According to the "Assigned clock parents and rates" section in
> Documentation/devicetree/bindings/clock/clock-bindings.txt,
> this should be:
> 			assigned-clocks = <&topckgen CLK_TOP_MM_SEL>;
> 			assigned-clock-rates = <400000000>;
> 
Ok, will do.
> regards
> Philipp
> 

-- 
Bibby