From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbcG2Pit (ORCPT ); Fri, 29 Jul 2016 11:38:49 -0400 Received: from smtprelay0045.hostedemail.com ([216.40.44.45]:37505 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751557AbcG2Piq (ORCPT ); Fri, 29 Jul 2016 11:38:46 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2828:2911:3138:3139:3140:3141:3142:3352:3622:3653:3865:3868:3871:3874:4321:4425:5007:7875:10004:10400:10450:10455:10848:11232:11658:11783:11914:12050:12517:12519:12740:13069:13071:13311:13357:13439:13894:14180:14181:14659:14721:19904:19999:21060:21080:21324:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: shelf70_69489b61ff12c X-Filterd-Recvd-Size: 1631 Message-ID: <1469806721.3998.80.camel@perches.com> Subject: Re: [PATCH] checkpatch: check signoff when reading stdin From: Joe Perches To: Allen Hubbe Cc: linux-kernel@vger.kernel.org, Andy Whitcroft , Andrew Morton Date: Fri, 29 Jul 2016 08:38:41 -0700 In-Reply-To: References: <5e6441a147be1d796620d1e302e1c73daa8c0b86.1469656370.git.allenbh@gmail.com> <1469666514.3998.14.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-07-29 at 10:45 -0400, Allen Hubbe wrote: > On Wed, Jul 27, 2016 at 8:41 PM, Joe Perches wrote: > > > > I think this is not a great idea because the most likely > > use case is piping git diff output ala: > > > > $ git diff | ./scripts/checkpatch.pl - > Thanks for the review.  Has v2 addressed your concern? Hi Allen. For the most part, yes, your V2 works better. I was wondering if the - should be optional and thinking $ git diff | ./scripts/checkpatch.pl should work the same way, but I guess that can wait for another day, so Acked-by: Joe Perches cheers, Joe