From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978AbcG3DCz (ORCPT ); Fri, 29 Jul 2016 23:02:55 -0400 Received: from omzsmtpe01.verizonbusiness.com ([199.249.25.210]:44982 "EHLO omzsmtpe01.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbcG3DCQ convert rfc822-to-8bit (ORCPT ); Fri, 29 Jul 2016 23:02:16 -0400 X-IronPort-Anti-Spam-Filtered: false From: "Levin, Alexander" Cc: "linux-kernel@vger.kernel.org" , Ben Hutchings , "Levin, Alexander" X-IronPort-AV: E=Sophos;i="5.28,442,1464652800"; d="scan'208";a="745042775" To: "mingo@redhat.com" , "peterz@infradead.org" Date: Fri, 29 Jul 2016 23:02:14 -0400 Subject: [PATCH 7/8] liblockdep: Fix 'defined but not used' warning for init_utsname() Thread-Topic: [PATCH 7/8] liblockdep: Fix 'defined but not used' warning for init_utsname() Thread-Index: AdHqDsZcDWIO5U3UThyLbqVQcfjyEw== Message-ID: <1469847222-21313-8-git-send-email-alexander.levin@verizon.com> References: <1469847222-21313-1-git-send-email-alexander.levin@verizon.com> In-Reply-To: <1469847222-21313-1-git-send-email-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ben Hutchings We define init_utsname() as static but not inline, resulting in a warning for every source file that includes lockdep.h but doesn't call it. Since it is only used by lockdep.c, define it in there. Signed-off-by: Ben Hutchings Signed-off-by: Sasha Levin --- tools/lib/lockdep/lockdep.c | 10 ++++++++++ tools/lib/lockdep/uinclude/linux/lockdep.h | 10 ---------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/lib/lockdep/lockdep.c b/tools/lib/lockdep/lockdep.c index 443acb1..209f967 100644 --- a/tools/lib/lockdep/lockdep.c +++ b/tools/lib/lockdep/lockdep.c @@ -12,4 +12,14 @@ u32 prandom_u32(void) abort(); } +static struct new_utsname *init_utsname(void) +{ + static struct new_utsname n = (struct new_utsname) { + .release = "liblockdep", + .version = LIBLOCKDEP_VERSION, + }; + + return &n; +} + #include "../../../kernel/locking/lockdep.c" diff --git a/tools/lib/lockdep/uinclude/linux/lockdep.h b/tools/lib/lockdep/uinclude/linux/lockdep.h index d107903..c157242 100644 --- a/tools/lib/lockdep/uinclude/linux/lockdep.h +++ b/tools/lib/lockdep/uinclude/linux/lockdep.h @@ -44,16 +44,6 @@ static inline int debug_locks_off(void) #define atomic_t unsigned long #define atomic_inc(x) ((*(x))++) -static struct new_utsname *init_utsname(void) -{ - static struct new_utsname n = (struct new_utsname) { - .release = "liblockdep", - .version = LIBLOCKDEP_VERSION, - }; - - return &n; -} - #define print_tainted() "" #define static_obj(x) 1 -- 2.7.4