From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbcGaCw7 (ORCPT ); Sat, 30 Jul 2016 22:52:59 -0400 Received: from omzsmtpe01.verizonbusiness.com ([199.249.25.210]:37791 "EHLO omzsmtpe01.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbcGaCwu convert rfc822-to-8bit (ORCPT ); Sat, 30 Jul 2016 22:52:50 -0400 X-IronPort-Anti-Spam-Filtered: false From: "Levin, Alexander" Cc: "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Levin, Alexander" X-IronPort-AV: E=Sophos;i="5.28,448,1464652800"; d="scan'208";a="745495499" To: "sgoutham@cavium.com" , "rric@kernel.org" Date: Sat, 30 Jul 2016 22:49:44 -0400 Subject: [PATCH] net: thunderx: correct bound check in nic_config_loopback Thread-Topic: [PATCH] net: thunderx: correct bound check in nic_config_loopback Thread-Index: AdHq1p19EeSUjDtpTyKji5VIkT3dXw== Message-ID: <1469933384-16827-1-git-send-email-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Off by one in nic_config_loopback would access an invalid arrat variable when vf id == MAX_LMAC. Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c index 16ed203..a70f50d 100644 --- a/drivers/net/ethernet/cavium/thunder/nic_main.c +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c @@ -615,7 +615,7 @@ static int nic_config_loopback(struct nicpf *nic, struct set_loopback *lbk) { int bgx_idx, lmac_idx; - if (lbk->vf_id > MAX_LMAC) + if (lbk->vf_id >= MAX_LMAC) return -1; bgx_idx = NIC_GET_BGX_FROM_VF_LMAC_MAP(nic->vf_lmac_map[lbk->vf_id]); -- 2.7.4