From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbdCGDcH (ORCPT ); Mon, 6 Mar 2017 22:32:07 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:33653 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754753AbdCGDcD (ORCPT ); Mon, 6 Mar 2017 22:32:03 -0500 Subject: Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes To: James Hogan References: <1488827635-7708-1-git-send-email-linux@roeck-us.net> <20170306232019.GG2878@jhogan-linux.le.imgtec.org> Cc: Ralf Baechle , Herbert Xu , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Ingo Molnar From: Guenter Roeck Message-ID: <146eef7a-44dd-48ff-3f09-0b342d844bd6@roeck-us.net> Date: Mon, 6 Mar 2017 19:30:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170306232019.GG2878@jhogan-linux.le.imgtec.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/2017 03:20 PM, James Hogan wrote: > Hi Guenter, > > On Mon, Mar 06, 2017 at 11:13:55AM -0800, Guenter Roeck wrote: >> Since commit f3ac60671954 ("sched/headers: Move task-stack related >> APIs from to ") and commit >> f780d89a0e82 ("sched/headers: Remove from >> "), various mips builds fail as follows. >> >> arch/mips/kernel/smp-mt.c: In function ‘vsmp_boot_secondary’: >> arch/mips/include/asm/processor.h:384:41: error: >> implicit declaration of function ‘task_stack_page’ >> >> In file included from >> /opt/buildbot/slave/hwmon-testing/build/arch/mips/kernel/pm.c: >> arch/mips/include/asm/fpu.h: In function '__own_fpu': >> arch/mips/include/asm/processor.h:385:31: error: >> invalid application of 'sizeof' to incomplete type 'struct pt_regs' > > This one is in an inline function, so I think it'd affect multiple > includes of even if __own_fpu isn't used, so I think the > following patch which adds the include ptrace.h in fpu.h is more robust > than adding to the individual c files affected: > https://patchwork.linux-mips.org/patch/15386/ > Agreed. > Admitedly it could probably have a more specific subject line since > there are more similar errors. Does that fix all compile problems ? Seems to me that we'll still need -#include +#include or did you prepare a patch for this as well ? Thanks, Guenter > > Cheers > James > >> >> arch/mips/netlogic/common/smp.c: In function 'nlm_boot_secondary': >> arch/mips/netlogic/common/smp.c:157:2: error: >> implicit declaration of function 'task_stack_page' >> >> and more similar errors. >> >> Fixes: f3ac60671954 ("sched/headers: Move task-stack related APIs ...") >> Fixes: f780d89a0e82 ("sched/headers: Remove from ...") >> Cc: Ingo Molnar >> Signed-off-by: Guenter Roeck >> --- >> v3: Catch more build errors >> >> arch/mips/cavium-octeon/cpu.c | 3 ++- >> arch/mips/cavium-octeon/crypto/octeon-crypto.c | 1 + >> arch/mips/cavium-octeon/smp.c | 2 +- >> arch/mips/kernel/pm.c | 1 + >> arch/mips/kernel/smp-mt.c | 2 +- >> arch/mips/netlogic/common/smp.c | 1 + >> arch/mips/netlogic/xlp/cop2-ex.c | 3 ++- >> arch/mips/power/cpu.c | 1 + >> 8 files changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/arch/mips/cavium-octeon/cpu.c b/arch/mips/cavium-octeon/cpu.c >> index a5b427909b5c..b826b7a87c57 100644 >> --- a/arch/mips/cavium-octeon/cpu.c >> +++ b/arch/mips/cavium-octeon/cpu.c >> @@ -10,7 +10,8 @@ >> #include >> #include >> #include >> -#include >> +#include >> +#include >> >> #include >> #include >> diff --git a/arch/mips/cavium-octeon/crypto/octeon-crypto.c b/arch/mips/cavium-octeon/crypto/octeon-crypto.c >> index 4d22365844af..cfb4a146cf17 100644 >> --- a/arch/mips/cavium-octeon/crypto/octeon-crypto.c >> +++ b/arch/mips/cavium-octeon/crypto/octeon-crypto.c >> @@ -9,6 +9,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "octeon-crypto.h" >> >> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c >> index 4b94b7fbafa3..d475c0146347 100644 >> --- a/arch/mips/cavium-octeon/smp.c >> +++ b/arch/mips/cavium-octeon/smp.c >> @@ -10,8 +10,8 @@ >> #include >> #include >> #include >> -#include >> #include >> +#include >> #include >> #include >> >> diff --git a/arch/mips/kernel/pm.c b/arch/mips/kernel/pm.c >> index dc814892133c..fab05022ab39 100644 >> --- a/arch/mips/kernel/pm.c >> +++ b/arch/mips/kernel/pm.c >> @@ -11,6 +11,7 @@ >> >> #include >> #include >> +#include >> >> #include >> #include >> diff --git a/arch/mips/kernel/smp-mt.c b/arch/mips/kernel/smp-mt.c >> index e077ea3e11fb..effc1ed18954 100644 >> --- a/arch/mips/kernel/smp-mt.c >> +++ b/arch/mips/kernel/smp-mt.c >> @@ -18,7 +18,7 @@ >> * Copyright (C) 2006 Ralf Baechle (ralf@linux-mips.org) >> */ >> #include >> -#include >> +#include >> #include >> #include >> #include >> diff --git a/arch/mips/netlogic/common/smp.c b/arch/mips/netlogic/common/smp.c >> index 10d86d54880a..9035558920c1 100644 >> --- a/arch/mips/netlogic/common/smp.c >> +++ b/arch/mips/netlogic/common/smp.c >> @@ -37,6 +37,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> >> diff --git a/arch/mips/netlogic/xlp/cop2-ex.c b/arch/mips/netlogic/xlp/cop2-ex.c >> index 52bc5de42005..d990b7fc84aa 100644 >> --- a/arch/mips/netlogic/xlp/cop2-ex.c >> +++ b/arch/mips/netlogic/xlp/cop2-ex.c >> @@ -13,7 +13,8 @@ >> #include >> #include >> #include >> -#include >> +#include >> +#include >> >> #include >> #include >> diff --git a/arch/mips/power/cpu.c b/arch/mips/power/cpu.c >> index 2129e67723ff..6ecccc26bf7f 100644 >> --- a/arch/mips/power/cpu.c >> +++ b/arch/mips/power/cpu.c >> @@ -7,6 +7,7 @@ >> * Author: Hu Hongbing >> * Wu Zhangjin >> */ >> +#include >> #include >> #include >> #include >> -- >> 2.7.4 >> >>