From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752393AbcHAJOT (ORCPT ); Mon, 1 Aug 2016 05:14:19 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55053 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbcHAJNy (ORCPT ); Mon, 1 Aug 2016 05:13:54 -0400 Message-ID: <1470042801.3025.17.camel@pengutronix.de> Subject: Re: [PATCH v3 10/12] gpu: ipu-v3: Add FSU channel linking support From: Philipp Zabel To: Steve Longerbeam Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Steve Longerbeam Date: Mon, 01 Aug 2016 11:13:21 +0200 In-Reply-To: <1469994147-17549-11-git-send-email-steve_longerbeam@mentor.com> References: <1469994147-17549-1-git-send-email-steve_longerbeam@mentor.com> <1469994147-17549-11-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, den 31.07.2016, 12:42 -0700 schrieb Steve Longerbeam: > Adds functions to link and unlink source channels to sink > channels in the FSU: > > int ipu_fsu_link(struct ipu_soc *ipu, int src_ch, int sink_ch); > int ipu_fsu_unlink(struct ipu_soc *ipu, int src_ch, int sink_ch); > > The channels numbers are usually IDMAC channels, but they can also be > channels that do not transfer data to or from memory. The following > convenience functions can be used in place of ipu_fsu_link/unlink() > when both source and sink channels are IDMAC channels: > > int ipu_idmac_link(struct ipuv3_channel *src, struct ipuv3_channel *sink); > int ipu_idmac_unlink(struct ipuv3_channel *src, struct ipuv3_channel *sink); > > So far the following links are supported: > > IPUV3_CHANNEL_IC_PRP_ENC_MEM -> IPUV3_CHANNEL_MEM_ROT_ENC > PUV3_CHANNEL_IC_PRP_VF_MEM -> IPUV3_CHANNEL_MEM_ROT_VF > IPUV3_CHANNEL_IC_PP_MEM -> IPUV3_CHANNEL_MEM_ROT_PP > IPUV3_CHANNEL_CSI_DIRECT -> IPUV3_CHANNEL_CSI_VDI_PREV Looks good to me, thanks. Are you sure though that the target of the CSI direct channel is VDI_PREV? I would have assumed the CSI input is fed into VDI_NEXT, while CUR and PREV are read from memory. regards Philipp