From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754101AbcHBSpg (ORCPT ); Tue, 2 Aug 2016 14:45:36 -0400 Received: from mail-ve1eur01on0114.outbound.protection.outlook.com ([104.47.1.114]:42531 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752337AbcHBSpY (ORCPT ); Tue, 2 Aug 2016 14:45:24 -0400 X-Greylist: delayed 14558 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Aug 2016 14:45:23 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; From: Andrey Ryabinin To: Andrew Morton CC: Alexander Potapenko , Dave Jones , Vegard Nossum , "Sasha Levin" , Dmitry Vyukov , , , , Andrey Ryabinin Subject: [PATCH 3/6] mm/kasan, slub: don't disable interrupts when object leaves quarantine Date: Mon, 1 Aug 2016 17:45:12 +0300 Message-ID: <1470062715-14077-3-git-send-email-aryabinin@virtuozzo.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1470062715-14077-1-git-send-email-aryabinin@virtuozzo.com> References: <1470062715-14077-1-git-send-email-aryabinin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM3PR08CA0029.eurprd08.prod.outlook.com (10.160.207.167) To VI1PR0801MB1982.eurprd08.prod.outlook.com (10.173.74.15) X-MS-Office365-Filtering-Correlation-Id: 1f4ec711-c3c8-4293-0601-08d3ba1a4c13 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1982;2:/NqKOvFFtK3rqQ+A0JJCKF5GeS0jCXVqyl31MbC3lrStStextT/wjFowdO33U0Awn5n/EFGjtFEcmqpDydH/x03uBf9LDgdhY/sI5acBeVTEd9qXtSDq6zIYRLu/m8BR5IpEe7cLAa+cYkdzcke93LjdJkQHoMPYm+j9oc8j4jAP79ALN5mASuSqeTStCFHa;3:JaL1kdZBwZr80aPfi8Psylg+nOkgVXOB4ApIe8qLm3O2BfqX/4sZYjySMt7MtCxNbD5IqhE85Lo/ftVPC72GBF71Ca3fYZN0jQ5bGxdt0EPQySsJ7QlsIy1yMq5WNd0i;25:rEKy8nGtQ2RMgu9UA8j5+BN4IIc2lspoLmtqPoyLMOxjBzGbtQuM7BxaE7WRoDAubMLSJuyRmcTm+goE/PYA1bLr+aLMWxk6UTP7Ll/3PHl0XSVIobvZFrBwURMIrmeuak5mWkJQ30or+ncmUoG4ApcQn0WkylJJUdom/VHLSTUYNS9IVUMnhEyAUsjsGuF1GxphqlNtkcSpAmSpwDU0Qnq5qUO/t47DA+M+WQTmOM9iX3RMTieCEnsssFnMfQqnWG2ssfl3moUTB+DBXhmB3XmNnF9XgTbAQ/waxOPeg0w4oEpgH9bXyWPb/LMOjd63686Wg6tlEpL8cztmfNNhkX8DJEauFIeyMnXVGLx7ylFCerU6C0/jQJWp2BW+guGFv0FVSuJALHZ/+sIqzQs+X/5+rTEm6Al/8aqIwuFQFIg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1982; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1982;31:Fs9RNeGXVlLFLlUrgZCk4x9FecgZx4fqWiMmdOaZvqORpFmFGH/Ipq6rMdoVlxRr1dFSjmnMezUkro2+KulkqhCwBteESD00kV2yewO0qFOhAFQHfluk3dPtdmsOG1UC5FslxiwKQ30SAtmdeE8fFuw46M71OvNhneSb1fHsMq5giLI3xGirk0zbb/M369xCZdW6A5+cjgTsl/2tUnTHzwINubVn8/53XMEIcv/fmNU=;4:cl4FvRCPjLZEk8uddAWACbUAQDW1UzKs/zgmaOfltzHwI9ruxygfV6dd5zgSGD3riqb/Sdr1MPDXjadMUi8ehRv1hIAm8LzLT9nETrLV2ony9F3cXFzOBoWqA3T2ZUHpAOhMc9LewEAlWQ4PEMKdMSoPbg1+vLLKixP4uFJjY5AYVco6kZ1zamb+hCsQG4vzQgxcZ2jWqC4QORQ2nwSMFZTFpwFOcVhwOpeCBh4f4S2x++YjQNBs3Drk6Zzwo0fSnhoV5c8zO7MtqwoONf1z3DEHKD3wozhB2wg2OErX5egbxd2XU1tbNF3UPQ0MBupYB5UpQNCvfJvVbGTSKJsrI1l1Jm0lSf6MYkbcPezdsulrmHD6HDKnnvIUQdERAWAZ4J81yyNDybKrrY9kwUHO87++VbbsQo/5FMq/Az13nmM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:VI1PR0801MB1982;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1982; X-Forefront-PRVS: 0021920B5A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(199003)(189002)(97736004)(92566002)(76176999)(36756003)(47776003)(8676002)(101416001)(81166006)(42186005)(81156014)(189998001)(3846002)(6116002)(5003940100001)(107886002)(4326007)(50466002)(110136002)(305945005)(48376002)(66066001)(586003)(69596002)(4001430100002)(2906002)(77096005)(50226002)(86362001)(33646002)(106356001)(2950100001)(229853001)(68736007)(50986999)(19580405001)(19580395003)(53416004)(7846002)(7736002)(105586002)(76506005);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1982;H:localhost.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0801MB1982;23:9dT2WPRaqCuO2qLFu1qK9PBsQ3pGXPbxkoo/QZA?= =?us-ascii?Q?A6rEOXzd2blA7zVsU/nllK22YYmcFUvZ58M9n1IK0hfU2Xj0abRgwqFxvMG8?= =?us-ascii?Q?vBqrQg3YdM7peNmdBUwDJRIdxbXuIAYxHDscKHvfuUKyJEVdA4HwE8KDt4Cd?= =?us-ascii?Q?vhpGIm0mwzc4P90WPxg83/TXdH9Cks/Wm01d7nAWaxOq2SCGDmskLE3qyTf3?= =?us-ascii?Q?pVpfGH8qFgEIl3wpFzJ8E7Et9COKzu3145rJTgPky+6V+YBqQWxljx0uWQjd?= =?us-ascii?Q?LuKcGxGgy3yy5EluZRTW24773G4bvGH2Q9zojKwPwRDj6WBUmOkkUf+Yl9XH?= =?us-ascii?Q?gjOV8gvufjCWCibxAfCTEGWjduAqHURvUsz9+Nbbn6Kl61WW3uvcM02JFDxJ?= =?us-ascii?Q?T7+astnNSLfXAVVhJPZ9Hhq1NvfoXYFMB+egWjSxnlLcZh0OAmh8bQDMjJoU?= =?us-ascii?Q?HZrz8pTQFUevSQ7iL+R4OTmS15MxktBqxMyX4hZWWe1+6gQztahcmuy2Cwsr?= =?us-ascii?Q?Y0HMynCYBuxcA1u1kEZaFbB/b2EvW9qcgOxwcZEwPjOy8WHQDbJvKiDH5QKl?= =?us-ascii?Q?vGl6bty7228Ckfsfo0hTMxOwCXmzEmwg31Tet6TfSYCiKPswfeG/KKT2oahm?= =?us-ascii?Q?SOHswmjroV2Oj5t6PpNbVExwaYt7PnaKd0zNbeCmJfzzAsWYeEtVpjwBJCfd?= =?us-ascii?Q?7YLflFHo6uaDZ0PCs5GcxasiwcDwnDRjoG98J1QwoV6hP6TzbuQYOy2lY/nN?= =?us-ascii?Q?BVegjd/lSO0uzsVy7+XVw63Iuhd4b1mbjCQa5sbbZKh0jNmr8kpUrJH7MX1g?= =?us-ascii?Q?/x88F8XQ+dZU0alT6xu8Jix9r+WRo8ENzzA2ba30+VYehSsIjU1ufwLd3ryL?= =?us-ascii?Q?fFUPlLgtDZscHJLiNPECXlYcSphz5Bm07JjcT/fES+4Dh+AbQ7NiEE64ONAg?= =?us-ascii?Q?aqCLHXDsLeA1flaGJSxXh75Xc1eKlK2mGfIEr7M1txDWhcDz4c21xDQ3IXBk?= =?us-ascii?Q?17jbUiXyA0TkkzTx+xJRADK/HMs46+xMuJfiutWzbaU3CwS8uPvq7/reYGDo?= =?us-ascii?Q?WFEWQVN5JdX6oHnOlBCVM2Ixk0gIpoldxWZV78Fe5xznLTtBxCnN+8WAoAgs?= =?us-ascii?Q?8kqC5k3Apm/+N35TMfzZ44j+5nbghpgqzbtJhkOJVthGttrPjB6Ts+ReDkIw?= =?us-ascii?Q?6oXyDski/VWWHMbs=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1982;6:qS31qcqcNI4G5v/11baG3R+3kkQ7D74uUdxoICUUeQWplPt1Jy8b/J/I9yO4DuV5Tq9KZXGxKCCw1ORF18RkATgwVMz18ryWPpohwg+uhCFwJ6ndMgyuSINxijacIC8WIRky3+JSWzAUUwbTGJ8U6LT6aoXZbcsaBG2XyLVXDPltOzbLwcsraOqTeR2rHzhZmYvDdlOAhcRwOLVE4TaUDJmfZBh7x0ZxvM/VDVh11+2V33TKsW3nONGFqJf6XCfWsCnyeKrgs0Uz2k2584GuMJOqStGlyixNMNQEw02IqzA5VXhk8969sCgCJAlRo27y;5:QmD49m0UEEuMHmVy4cxmuhz7Gh/vCvZ1KGVkFg7OFk9KVyYgGl87rjZTquza/a9WZBVx98DD5Zt1xZ02RUrzspajonwpaTe99VIuwX8b+8RLe6zSBZurAm538A1z0tph6iaqrJWzxWSLVgrRCsSQJQ==;24:2/0jAcW3Nd/WQOnZokBRWldEjPKlEl0KvSBtuC0+BCoICv6MhkyzjIeXpf2+KYKS4cYevyFz3vlgpYJB7hL5lVPgH4UqIf5jy+VCqjFpmVU=;7:DVcY4njEJXYUoxmA7DE7OiE/ftYmZwUttNFmx+Bh8K7pxK2kXKVLYIX8Yr8xH1Rlc3cirUXvhgnE+9lxvZJAUmUEfF4OnBXGrhUacuq14pKxkb+fXY6b3FdtwcWLLX9AEzjOvKTgxrdnU1CxWoCasA8Mt+qPpgd+me27s7DvwfGL9vDn3RoZGEIzdX/8r6DMqA+kQ1YXVci8D5lu1v2k8yBViIzzCVyJhNdfwVENkNVTGqSBvrXICCjUbfHCrpjb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1982;20:LKN2NlJGpzXIf25Ps2hhhsEEpcNNf8/bKWXG+pXTSDJWNzCKszZJBYj+tni3fF6TSqm6cg11R52ypWIH8dwHLX3Yy5zdEdqE881Ky2skLx3HY+MFPz6bHj1wYKMu7hmqm0goq6wKxa+rC43DNS6t4rxlBb7QgfoQeNNDJ/VGRi8= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 14:44:08.9025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1982 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SLUB doesn't require disabled interrupts to call ___cache_free(). Signed-off-by: Andrey Ryabinin --- mm/kasan/quarantine.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c index 65793f1..4852625 100644 --- a/mm/kasan/quarantine.c +++ b/mm/kasan/quarantine.c @@ -147,10 +147,14 @@ static void qlink_free(struct qlist_node *qlink, struct kmem_cache *cache) struct kasan_alloc_meta *alloc_info = get_alloc_info(cache, object); unsigned long flags; - local_irq_save(flags); + if (IS_ENABLED(CONFIG_SLAB)) + local_irq_save(flags); + alloc_info->state = KASAN_STATE_FREE; ___cache_free(cache, object, _THIS_IP_); - local_irq_restore(flags); + + if (IS_ENABLED(CONFIG_SLAB)) + local_irq_restore(flags); } static void qlist_free_all(struct qlist_head *q, struct kmem_cache *cache) -- 2.7.3