From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756586AbcHCBrI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 21:47:08 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:42010 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754015AbcHCBrD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 21:47:03 -0400
Message-ID: <1470188816.5418.8.camel@mtksdaap41>
Subject: Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
CC: Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
        "Pawel Moll" <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        James Liao <jamesjj.liao@mediatek.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        YH Huang <yh.huang@mediatek.com>, "CK Hu" <ck.hu@mediatek.com>,
        Yong Wu <yong.wu@mediatek.com>, Eddie Huang <eddie.huang@mediatek.com>,
        "dawei.chien@mediatek.com" <dawei.chien@mediatek.com>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Junzhi Zhao <junzhi.zhao@mediatek.com>
Date: Wed, 3 Aug 2016 09:46:56 +0800
In-Reply-To: <1469785990.3012.35.camel@pengutronix.de>
References: <1469783388-56804-1-git-send-email-bibby.hsieh@mediatek.com>
	 <1469785990.3012.35.camel@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Philipp,

On Fri, 2016-07-29 at 11:53 +0200, Philipp Zabel wrote:
> Hi Bibby,
> 
> Am Freitag, den 29.07.2016, 17:09 +0800 schrieb Bibby Hsieh:
> > To support HDMI 4K resolution, mmsys need clcok
> > mm_sel to be 400MHz.
> > 
> > The board .dts file should override the clock rate
> > property with the higher VENCPLL frequency the board
> > supports HDMI 4K resolution.
> > 
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 78529e4..93d4d17 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -690,6 +690,8 @@
> >  			compatible = "mediatek,mt8173-mmsys", "syscon";
> >  			reg = <0 0x14000000 0 0x1000>;
> >  			power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > +			clocks = <&topckgen CLK_TOP_MM_SEL>;
> > +			clock-frequency  = <400000000>;
> 
> This is unchanged compared to v3, I suggest to use assigned-clocks /
> assigned-clock-rates properties instead.
> 
Ok, I will change that, thanks for your review.

-- 
Bibby
> best regards
> Philipp
>