From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758355AbcHCUUz (ORCPT ); Wed, 3 Aug 2016 16:20:55 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:41589 "EHLO laurent.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758123AbcHCUUx (ORCPT ); Wed, 3 Aug 2016 16:20:53 -0400 From: Geert Uytterhoeven To: Michal Hocko , Andrew Morton Cc: Oleg Nesterov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH/RFC] mm, oom: Fix uninitialized ret in task_will_free_mem() Date: Wed, 3 Aug 2016 22:19:59 +0200 Message-Id: <1470255599-24841-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mm/oom_kill.c: In function ‘task_will_free_mem’: mm/oom_kill.c:767: warning: ‘ret’ may be used uninitialized in this function If __task_will_free_mem() is never called inside the for_each_process() loop, ret will not be initialized. Fixes: 1af8bb43269563e4 ("mm, oom: fortify task_will_free_mem()") Signed-off-by: Geert Uytterhoeven --- Untested. I'm not familiar with the code, hence the default value of true was deducted from the logic in the loop (return false as soon as __task_will_free_mem() has returned false). --- mm/oom_kill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 7d0a275df822e9e1..d53a9aa00977cbd0 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -764,7 +764,7 @@ bool task_will_free_mem(struct task_struct *task) { struct mm_struct *mm = task->mm; struct task_struct *p; - bool ret; + bool ret = true; /* * Skip tasks without mm because it might have passed its exit_mm and -- 1.9.1