From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161101AbcHEJ0P (ORCPT ); Fri, 5 Aug 2016 05:26:15 -0400 Received: from hotel311.server4you.de ([85.25.146.15]:47046 "EHLO hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934805AbcHEJ0K (ORCPT ); Fri, 5 Aug 2016 05:26:10 -0400 From: Daniel Wagner To: linux-kernel@vger.kernel.org Cc: Alex Dubov , Ashutosh Dixit , Greg Kroah-Hartman , Sudeep Dutt , Wolfram Sang , Daniel Wagner Subject: [PATCH 1/4] misc: mic: scif: use complete() instead of complete_all() Date: Fri, 5 Aug 2016 11:26:00 +0200 Message-Id: <1470389163-4594-2-git-send-email-wagi@monom.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470389163-4594-1-git-send-email-wagi@monom.org> References: <1470389163-4594-1-git-send-email-wagi@monom.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Wagner There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context waker context scif_get_node_info() DECLARE_COMPLETION_ONSTACK(node_info); msg->payload[3] = node_info scif_nodeqp_send() wait_for_completion(node_info) scif_get_node_info_resp() node_info = msg->payload[3] complete(node_info) Signed-off-by: Daniel Wagner --- drivers/misc/mic/scif/scif_nodeqp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mic/scif/scif_nodeqp.c b/drivers/misc/mic/scif/scif_nodeqp.c index c66ca1a..c9b3b64 100644 --- a/drivers/misc/mic/scif/scif_nodeqp.c +++ b/drivers/misc/mic/scif/scif_nodeqp.c @@ -1009,7 +1009,7 @@ scif_get_node_info_resp(struct scif_dev *scifdev, struct scifmsg *msg) mutex_lock(&scif_info.conflock); scif_info.maxid = msg->payload[1]; scif_info.total = msg->payload[2]; - complete_all(node_info); + complete(node_info); mutex_unlock(&scif_info.conflock); } } -- 2.7.4