From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759616AbcHEJ1M (ORCPT ); Fri, 5 Aug 2016 05:27:12 -0400 Received: from hotel311.server4you.de ([85.25.146.15]:47056 "EHLO hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934814AbcHEJ0L (ORCPT ); Fri, 5 Aug 2016 05:26:11 -0400 From: Daniel Wagner To: linux-kernel@vger.kernel.org Cc: Alex Dubov , Ashutosh Dixit , Greg Kroah-Hartman , Sudeep Dutt , Wolfram Sang , Daniel Wagner Subject: [PATCH 2/4] misc: mic: vop: use complete() instead of complete_all() Date: Fri, 5 Aug 2016 11:26:01 +0200 Message-Id: <1470389163-4594-3-git-send-email-wagi@monom.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470389163-4594-1-git-send-email-wagi@monom.org> References: <1470389163-4594-1-git-send-email-wagi@monom.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Wagner There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context waker context _vop_remove_device() reinit_completion() wait_for_completion() vop_reset() complete() Signed-off-by: Daniel Wagner --- drivers/misc/mic/vop/vop_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c index 1a2b67f3..f4ed4a8 100644 --- a/drivers/misc/mic/vop/vop_main.c +++ b/drivers/misc/mic/vop/vop_main.c @@ -229,7 +229,7 @@ static void vop_reset(struct virtio_device *dev) __func__, dev->id.device); vop_reset_inform_host(dev); - complete_all(&vdev->reset_done); + complete(&vdev->reset_done); } /* -- 2.7.4