From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759587AbcHEJ05 (ORCPT ); Fri, 5 Aug 2016 05:26:57 -0400 Received: from hotel311.server4you.de ([85.25.146.15]:47063 "EHLO hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934856AbcHEJ0M (ORCPT ); Fri, 5 Aug 2016 05:26:12 -0400 From: Daniel Wagner To: linux-kernel@vger.kernel.org Cc: Alex Dubov , Ashutosh Dixit , Greg Kroah-Hartman , Sudeep Dutt , Wolfram Sang , Daniel Wagner Subject: [PATCH 3/4] misc: ti-st: use complete() instead of complete_all() Date: Fri, 5 Aug 2016 11:26:02 +0200 Message-Id: <1470389163-4594-4-git-send-email-wagi@monom.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470389163-4594-1-git-send-email-wagi@monom.org> References: <1470389163-4594-1-git-send-email-wagi@monom.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Wagner There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context waker context read_local_version() reinit_completion() st_int_write() wait_for_completion_interruptible_timeout() validate_firmware_response() complete() reinit_completion() Signed-off-by: Daniel Wagner --- drivers/misc/ti-st/st_kim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index bf0d770..0e1c94a 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -88,7 +88,7 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata) return; /* keep waiting for the proper response */ } /* becos of all the script being downloaded */ - complete_all(&kim_gdata->kim_rcvd); + complete(&kim_gdata->kim_rcvd); kfree_skb(skb); } -- 2.7.4