From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: [PATCH 2/3] lkdtm: Fix targets for objcopy usage
Date: Fri, 5 Aug 2016 14:25:52 -0700 [thread overview]
Message-ID: <1470432353-4297-3-git-send-email-keescook@chromium.org> (raw)
In-Reply-To: <1470432353-4297-1-git-send-email-keescook@chromium.org>
The targets for lkdtm's objcopy were missing which caused them to always
be rebuilt. This corrects the problem.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/misc/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 4387ccb79e64..7410c6d9a34d 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -69,5 +69,6 @@ OBJCOPYFLAGS :=
OBJCOPYFLAGS_lkdtm_rodata_objcopy.o := \
--set-section-flags .text=alloc,readonly \
--rename-section .text=.rodata
-$(obj)/lkdtm_rodata_objcopy.o: $(obj)/lkdtm_rodata.o
+targets += lkdtm_rodata.o lkdtm_rodata_objcopy.o
+$(obj)/lkdtm_rodata_objcopy.o: $(obj)/lkdtm_rodata.o FORCE
$(call if_changed,objcopy)
--
2.7.4
next prev parent reply other threads:[~2016-08-05 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 21:25 [PATCH 0/3] lkdtm: fixes for v4.8-rc1 Kees Cook
2016-08-05 21:25 ` [PATCH 1/3] lkdtm: fix false positive warning from -Wmaybe-uninitialized Kees Cook
2016-08-05 21:25 ` Kees Cook [this message]
2016-08-05 21:25 ` [PATCH 3/3] lkdtm: Mark lkdtm_rodata_do_nothing() notrace Kees Cook
2016-08-31 11:15 ` [PATCH 0/3] lkdtm: fixes for v4.8-rc1 Greg Kroah-Hartman
2016-08-31 14:46 ` Kees Cook
2016-08-31 15:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470432353-4297-3-git-send-email-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®