From: Joe Perches <joe@perches.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scripts/Lindent: clean up and optimize
Date: Sun, 07 Aug 2016 09:18:31 -0700 [thread overview]
Message-ID: <1470586711.28648.38.camel@perches.com> (raw)
In-Reply-To: <20160807174849.1e30bef7@endymion>
On Sun, 2016-08-07 at 17:48 +0200, Jean Delvare wrote:
> Hi Joe,
>
> On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> >
> > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > >
> > > * Add a few blank lines to improve readability.
> > > * Don't call cut 3 times when once is enough.
> > > * Drop a useless semicolon.
> > As it commonly reflows > 80 column code very badly,
> > my preference would be to remove Lindent instead.
> >
> > https://lkml.org/lkml/2013/2/11/390
> This was 3.5 years ago, so apparently it's not happening.
>
> Why don't you just remove -l80 from the options, if this is your only
> concern with the script?
line length is not context aware and you'd get > 256
column lines in a lot of cases.
> Adding the appropriate option to indent to
> support what we think is good would seem even better, but I do not have
> any time to devote to this task.
Nor does anyone else.
indent has had 1 change in 14 years.
clang-format might be a better tool and a better
suggestion than Lindent now.
prev parent reply other threads:[~2016-08-07 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 9:26 Jean Delvare
2016-08-05 17:53 ` Joe Perches
2016-08-07 15:48 ` Jean Delvare
2016-08-07 16:18 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470586711.28648.38.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome