From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbcHHQrW (ORCPT ); Mon, 8 Aug 2016 12:47:22 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:43001 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbcHHQrT (ORCPT ); Mon, 8 Aug 2016 12:47:19 -0400 From: Philipp Zabel To: linux-kernel@vger.kernel.org Cc: kernel@pengutronix.de, Philipp Zabel , Jon Hunter , Rob Herring Subject: [PATCH] Revert "of/irq: Mark initialised interrupt controllers as populated" Date: Mon, 8 Aug 2016 18:47:11 +0200 Message-Id: <1470674831-3092-1-git-send-email-p.zabel@pengutronix.de> X-Mailer: git-send-email 2.8.1 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 15cc2ed6dcf91a8658e084be4e140147161819d7 ("of/irq: Mark initialised interrupt controllers as populated"), which breaks the i.MX6 GPC (General Power Controller). The GPC is both an interrupt controller and a power domain controller. If the interrupt code sets the OF_POPULATED bit early, the power domain driver is silently skipped, as are the GPU and VPU drivers that are missing their power domain. Signed-off-by: Philipp Zabel Cc: Jon Hunter Cc: Rob Herring --- drivers/of/irq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 89a71c6..7d3f93f 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -559,8 +559,6 @@ void __init of_irq_init(const struct of_device_id *matches) * its children can get processed in a subsequent pass. */ list_add_tail(&desc->list, &intc_parent_list); - - of_node_set_flag(desc->dev, OF_POPULATED); } /* Get the next pending parent that might have children */ -- 2.8.1