From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932624AbcHIWMZ (ORCPT ); Tue, 9 Aug 2016 18:12:25 -0400 Received: from mail-bn3nam01on0041.outbound.protection.outlook.com ([104.47.33.41]:1177 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932486AbcHIWMV (ORCPT ); Tue, 9 Aug 2016 18:12:21 -0400 X-Greylist: delayed 965 seconds by postgrey-1.27 at vger.kernel.org; Tue, 09 Aug 2016 18:12:21 EDT Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; From: York Sun To: CC: , , , , York Sun , Doug Thompson , , Subject: [Patch v4 7/9] driver/edac/fsl_ddr: Fix kernel warning when module is removed Date: Tue, 9 Aug 2016 14:55:44 -0700 Message-ID: <1470779760-16483-8-git-send-email-york.sun@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470779760-16483-1-git-send-email-york.sun@nxp.com> References: <1470779760-16483-1-git-send-email-york.sun@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131152534427135635;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(54534003)(199003)(189002)(5003940100001)(47776003)(87936001)(8666005)(305945005)(68736007)(7846002)(50226002)(8936002)(81166006)(36756003)(189998001)(11100500001)(2906002)(81156014)(97736004)(19580395003)(8676002)(92566002)(19580405001)(4326007)(69596002)(50466002)(586003)(110136002)(33646002)(48376002)(106466001)(104016004)(86362001)(76176999)(356003)(2351001)(50986999)(105606002)(229853001)(85426001)(77096005)(2950100001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0301MB0599;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD029;1:pFUwGhwckgUfZUMvwVYuW6OYQmTYp5zTHZuNjVkBsY5Crg1MBv3iUWEkTlZB84mffolCEYiFb4ZtVg7ONWvRxLYElpUO4NVWzTOkbjHcjF5P/m2z7jHnRZSYyvPwRiq7Eg6C6TctEZoYdQHFbK5TVsxbVUGeLATheKxLBhfOaQ3kaceTsDmX97Eo71x0f8fjdmAQM+s7GzCXGe+WwUDcUQqLSL9B5gjxgS6QaP9lEF7RtDi4BlCoq1Su42nd68Nod7Jsi3lAK5odujU4G/mx3dLa9eHAdV5dbyYSIBgh/nMtK/3/MSizPlYqNJLcnZ8xTRrsbeSVLFQRckWruck4fkB/e646UKv4xeHtnxYfJ2dHOvZDOIynUz4TiC3HAKqRSgazYuS9CnJpG+06FnzRnFjgPZKHRQ31QP6SUmwfAjV/2jtQjq6vfvvhlL9MIdedJ/49V0m7Umq3KNrAwQ8dg+FbeICMw1B0bVSCaq6npfJg1/F+SQDlprN6ihCiQ9VFSmn6YI5X879nuOuhjbHLq+Y6rO4O2N/Z/4yYc5tP+BuGg/7LGKsJbKlJL5z0fqBIM1oxyaHIkEc5aFJbj4Ve4g== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 239e86e7-49df-4ac2-8d34-08d3c0a02460 X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0599;2:ucwbZJzmB8kc/Tyiv4Ypfub0TdnGrGp0O5ZwLjzzmpt3f4K7XOpuhex+nEdkwzIKs2z/MT1oQsDL3zqNaaiuYvnbpdDCSGhJGn80Ku8DL2OsIrh1gBzCp7om/7PYyv0SlmbXjt6sEOQ94pGmvOg9SKpJbSMXO5JQJ7lb3/+SgbL4rMlzp+/DsEmXeLzhvyLD;3:5cLS8dUIS+Rt0GOxMVpEuvkFDGxSfnkBPDa+52moy9NHLBdpIEIAuZEvQiBGOQ6GxkMgLrwBewdLlxwed4HO+Pq0O+L5K55gVgnmP9bipMdJkTYNcX67BNlBdJpNrI9Hqoi5jyst+12T+aavjDhxKb1kKY0WOhwV4T54gNMAUaOkvWlLC08GX9+VCbxqBs+LVFlYZl0hJkvA4NE4E/A8oCV9I2BuVC1N/Vhz2IIAQ/U=;25:w0LTL8LxJcSgE/VPhnz1QHsWfVazbBIo9G5hb3tGsIo6xS3jH4mflubWgl4hEOM4DFfJXxE0ILyMYirfPVyUIvxARS89E+CjSf7WQ3fcwe600WluKjFp06EyT1D1PzfG2z8TWBR01Eo5b0m1xV76EmmLZwaVUs+UAL6znF47BEYxZulsiOTPbkT9lsW88H6HOnSTfr1g1SES9s2MomKN2SfmDAIG2VaeX2jA8MiGIcnkcZDQzcgimr07Gj5ZBC6fQS2YekcJ19FODXDVIVsRkowCMqFnYEqVPZcMAsdJRMZ4GQtM242SYZim7T9TvNQFoJTXihaMAEj5CZ7CKtO+1ExOdCI32XnqmFOqzbk+HoRaq1B2fdsQRDDDI8+hASC+GjqGpICm/UibGenGjVU0tSCd+s3eW6WvPpF+H2bXwN8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0599; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0599;31:VcGpDo2zRV9NacFDhuThC47wGd0A2nBM8bjhgj3gGqC3LaN7nz2aU+ubnuEQMd3cvtCpr57KQiAxrjUccHT0Q9f/YEmRiLmUghs/75C0LLuhSukYOwShT2h8zPAtyMvfg2aPl0fyWYtlGSOQTBGY1oVvYGOkGXbMraWAREHDSlDFxNUXbOOOPNzZiagaobSY3yNdubQpiBTCow53vs0AKjgYdLWey+em9C88VIvhfl4=;4:7yNsfTl9iP6Vr4V7qncQtk3w3s8ZNluMPL0TO9hqRmHYpPu1L2lWAKGn+Fgk4mM6LrjyOc7FBe0k66sJS9SAG6CIuiO5YHeIwSrSC1Wo+qAu+Q53YOI3TyVfHOkqv1uNpNdSw7a5TsVep6bBR5OOG+B2jAHgTd83xnECeK2BuEFJa6vIa/M0MPenLBDHOJREA/5LFarRl+HW5ueTCTZYhezCfuz1xx1jXSTAhLzGfSgv+6QwNJ/rz06OhkbB8Rtd6ZxNYuArNjH4LuBZGVSn2ei/8UY65zVQRcMiqxXC6zeaQ+qfyuEHx8XoqNhjgRhic82xMUSghZLmADT2h/4RGQEnBArC8mpeJwrV9f71XjkSEnpBYd+GZ6hCp0xWwuQmFuSBCx+g7lC0+P8+J2PeoZHAZQWqs9MfYQ0TcrsQU+ST+wQdRCY+zLSFBHKnKZc0RjzLW0zJiVDQFBfql3FbvSENmAl+6+7W64SDl/Uc362szUCh0GPUo1g8g6PTJCw7unykQ9i8Hz4ROdaLsLYtoQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BY2PR0301MB0599;BCL:0;PCL:0;RULEID:(400006);SRVR:BY2PR0301MB0599; X-Forefront-PRVS: 0029F17A3F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR0301MB0599;23:HviOlFXA1zi7hv5x3xhzprwpZD607MZ++69ARpd?= =?us-ascii?Q?dDdLQJX00XjIzdPWpNo0Tgrd9siP2mfzMnk6GkquLcoo2RjL+q/JfeR4lcVk?= =?us-ascii?Q?cn194DYmFxIiZrawEjhgSvQnebctFGVtX0RX8VQvHDX5mg6c4WXsYxErDnAm?= =?us-ascii?Q?32+Pccv0YLxuM+PcCf7FPFA4EmaU+0OziSmIBcXSsm7LVPE9SRPlJ0i07IbP?= =?us-ascii?Q?DTl4WoOohMxUzpIVw2nPRbhRYw0PEjG4V6Fjl7Ks4YLg7hy4lpvOblI+LD6w?= =?us-ascii?Q?FRz4FK3OUmE24XZD4PMiawrIuBxsyAQPd24NAvTNiLsm0zn6PHD/myIPrDC8?= =?us-ascii?Q?vemIus/uH6L6yVnyPHIQ14T3AY4usb5uIydwOhHtVoDTcBov250lCEpFshND?= =?us-ascii?Q?kH6TRKBnCCw3o7EAmA14vta2kwUJGmnkuJz8U9z3kp9cyEdlkauieYpOldyf?= =?us-ascii?Q?EIpHcLMUT5E5bGns3MWbQc8mtTkR3z56+p6B64epEzkD9yr0zLLH0s7tcF76?= =?us-ascii?Q?gfzwuFnmPy+DkZnGVB9o7lwvXgdkev7kU0mOFaH6jkfLxMaY5I6iYyeSI8em?= =?us-ascii?Q?FD1IWa9ZcqQgEOkyfOzSsuUxNOuGZPWbPVo2vE/3/a8TgOpl35Fg1U9IPhxN?= =?us-ascii?Q?eSZSLST3IdSBD/aAtXHJxxj4FEYAY/irTQiihqL+sLgVLd+vpIjiBK1fdF/x?= =?us-ascii?Q?Y+LHuPw+g/F9IzoJbOq5zk+NwjmivqTgFZq4prXvHrcSJZiIVVNBaeREkDZ1?= =?us-ascii?Q?uXiJ0wag8cJK5KOWz0GUQebtnQBWjbuexseLEUZtcqR9F+K8tlwuqoxRCGEx?= =?us-ascii?Q?9rBBANYKngSzAkBCn35+sNJgh4WlWtFGa8hvkx1YZhfocPJnNH4C60FVllZ8?= =?us-ascii?Q?4UlCXueq0cvq9vIedHpTHQmXpJA9NCDvFq8hyKz6W0BKf4HGUyUNSOqHFE6T?= =?us-ascii?Q?GSQ8SsF/YhlkJzoj9C10EnVyv2quhc78oxL0OQJef7BCMV4pQ1k+urmCZgQc?= =?us-ascii?Q?VWf2SPTNuqmwq0o+4ylVwXvO8ql65zNMU04xMgaJNBtb0tN4uwkJoq0aortD?= =?us-ascii?Q?ThnM5ziaSKX9wpZVe69cfCT6lGkdxjEcaw697pPpFGYyccGwJ1X1441rCI8R?= =?us-ascii?Q?bXuL/FWkNDAVZP2qBJKLRiY+sZhOTq1mdwRU5tpYqaFW6k4CyeLtxxuHqoVb?= =?us-ascii?Q?5UMcZjidYo2PuiBM=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0599;6:YwVp3BZWUMRQpO0QvJdq7ED1T6X4ouhGcMS24EKb5E+IDWqW5fzT2gTkiu8mgwwTE2mDiJCJsbR6KFFKWmkerkQAXfIpSLAonOUDxmMDvUoqSXKAc4eozoAybaLYYaRVSsG+WMINFGanK8wpmenAb09uUTPPegRmQt3rtYKGn8DLqxcccy7gJndIv2z5iJP1WhDTN+icTeHNbZ15dLkT8oCTpx3g42jxRXbsxBFgGIwPg39t47C/IEdUECEWpgxXndiWOoSAW4dBan00FUCHE3e9dE2JvdDdlpK93QGooQc=;5:/2zencpdQt+VFfxDHVgz7FHsW+s9di7+yMVurALqaXrapB/a6rt8rnU88sArhi8VJBAoLk0/zjskaodyR+i8dmkytAvQilekkiS2bNxhdUx8cO8fxzcl/EtA78VGpUuefFAin3uLMcHkiw0yRah3P4lKcOLD5qUcazqk2soG6ZE=;24:lUxVZBNZILSlW2OCnOfWPwbD8HWy/WXXug+abqKvitK57n88lBmPVj/HXY+uC05WnvXrNT643rw+BMavkEhMHEcAIOtYSvzofvdKevamoc8=;7:Q1zdsS0xayG6EH4sHPq2qJqhYFKa4+j2ew3VbDXW5iD8gc1lxXQ8KbqjrzbdjC4Kl8lBujMggwRVpoHxls0KQND7n2s0NAcfEt9GkNUHXyEJ4Y+tXEVDPwrGVw3j4djfs1AmDQDfW/xcalT05o4cxI3R2H54qeoNqV37+Gf9FUxxkavAF8dYQaALjcK7m4q4Dzhu3rzMvmgzLA118XQxiAyQ08P6FbGCjCyZAO8B8ie9UwlvBomfF9xjLbJxQn6P SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2016 21:57:22.4795 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0599 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When compiled as a module, removing this module causes kernel warnings when irq_dispose_mapping() is called. Instead of calling irq_of_parse_and_map(), using platform_get_irq() to acquire the IRQ number. Signed-off-by: York Sun --- Change log v4: Absorb name changes by "Rename macros and names" v3: no change v2: no change drivers/edac/fsl_ddr_edac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c index 6d4dd84..d8ce1f6 100644 --- a/drivers/edac/fsl_ddr_edac.c +++ b/drivers/edac/fsl_ddr_edac.c @@ -563,7 +563,7 @@ int fsl_mc_err_probe(struct platform_device *op) ddr_out32(pdata->mc_vbase + FSL_MC_ERR_SBE, 0x10000); /* register interrupts */ - pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0); + pdata->irq = platform_get_irq(op, 0); res = devm_request_irq(&op->dev, pdata->irq, fsl_mc_isr, IRQF_SHARED, @@ -571,7 +571,6 @@ int fsl_mc_err_probe(struct platform_device *op) if (res < 0) { pr_err("%s: Unable to request irq %d for FSL DDR DRAM ERR\n", __func__, pdata->irq); - irq_dispose_mapping(pdata->irq); res = -ENODEV; goto err2; } @@ -602,7 +601,6 @@ int fsl_mc_err_remove(struct platform_device *op) edac_dbg(0, "\n"); if (edac_op_state == EDAC_OPSTATE_INT) { - irq_dispose_mapping(pdata->irq); ddr_out32(pdata->mc_vbase + FSL_MC_ERR_INT_EN, 0); } -- 2.7.4