From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938703AbcHJSq3 (ORCPT ); Wed, 10 Aug 2016 14:46:29 -0400 Received: from foss.arm.com ([217.140.101.70]:49397 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936596AbcHJSqY (ORCPT ); Wed, 10 Aug 2016 14:46:24 -0400 From: Dietmar Eggemann To: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org Cc: Morten Rasmussen , Vincent Guittot , Yuyang Du Subject: [PATCH] sched/fair: Fix load_above_capacity fixed point arithmetic width Date: Wed, 10 Aug 2016 11:27:27 +0100 Message-Id: <1470824847-5316-1-git-send-email-dietmar.eggemann@arm.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 2159197d6677 ("sched/core: Enable increased load resolution on 64-bit kernels") we now have two different fixed point units for load. load_above_capacity has to have 10 bit fixed point unit like PELT whereas NICE_0_LOAD has 20 bit fixed point unit on 64-bit kernels. Fix this by scaling down NICE_0_LOAD when multiplying load_above_capacity with it. Signed-off-by: Dietmar Eggemann Acked-by: Morten Rasmussen --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 4088eedea763..fe4093807852 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -7147,7 +7147,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s load_above_capacity = busiest->sum_nr_running * SCHED_CAPACITY_SCALE; if (load_above_capacity > busiest->group_capacity) { load_above_capacity -= busiest->group_capacity; - load_above_capacity *= NICE_0_LOAD; + load_above_capacity *= scale_load_down(NICE_0_LOAD); load_above_capacity /= busiest->group_capacity; } else load_above_capacity = ~0UL; -- 1.9.1