From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932174AbcHJSE1 (ORCPT ); Wed, 10 Aug 2016 14:04:27 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58616 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751059AbcHJSET (ORCPT ); Wed, 10 Aug 2016 14:04:19 -0400 From: Gregory CLEMENT To: Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Ezequiel Garcia , Maxime Ripard , Boris BREZILLON , Romain Perier , Stefan Roese , Sebastian Careba Subject: [PATCH v2] clocksource/drivers/time-armada-370-xp: Fix the clock reference Date: Wed, 10 Aug 2016 15:14:27 +0200 Message-Id: <1470834867-25932-1-git-send-email-gregory.clement@free-electrons.com> X-Mailer: git-send-email 2.8.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While converting the init function to return an error, the wrong clock was get. This lead to wrong clock rate and slow down the kernel. For example, before the patch a typical boot was around 15s after it was 1 minute slower. Fixes: 12549e27c63c ("clocksource/drivers/time-armada-370-xp: Convert init function to return error") Signed-off-by: Gregory CLEMENT --- Changelog: v1 -> v2 Move the of_clk_get_by_name out of the declaration as sugested by Thomas Petazzoni. drivers/clocksource/time-armada-370-xp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c index 719b478d136e..376ed13fe739 100644 --- a/drivers/clocksource/time-armada-370-xp.c +++ b/drivers/clocksource/time-armada-370-xp.c @@ -335,10 +335,10 @@ static int __init armada_370_xp_timer_common_init(struct device_node *np) static int __init armada_xp_timer_init(struct device_node *np) { - struct clk *clk = of_clk_get_by_name(np, "fixed"); + struct clk *clk; int ret; - clk = of_clk_get(np, 0); + clk = of_clk_get_by_name(np, "fixed"); if (IS_ERR(clk)) { pr_err("Failed to get clock"); return PTR_ERR(clk); -- 2.8.1