From: John Garry <john.garry@huawei.com>
To: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
Cc: <linuxarm@huawei.com>, <zhangfei.gao@linaro.org>,
<xuwei5@hisilicon.com>, <john.garry2@mail.dcu.ie>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
John Garry <john.garry@huawei.com>
Subject: [PATCH 7/8] hisi_sas: add TMF success check
Date: Wed, 10 Aug 2016 21:20:04 +0800 [thread overview]
Message-ID: <1470835205-65684-8-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1470835205-65684-1-git-send-email-john.garry@huawei.com>
When a tmf is issued, various response codes can be
returned from the target. For a query tmf the
response may be TMF_RESP_FUNC_COMPLETE or
TMF_RESP_FUNC_SUCC.
Add a condition for TMF_RESP_FUNC_SUCC to
hisi_sas_exec_internal_tmf_task().
This affects query tmf, as the result is success
the returned value was for failure.
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index af92b137..3ba8dc7 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -743,6 +743,12 @@ static int hisi_sas_exec_internal_tmf_task(struct domain_device *device,
}
if (task->task_status.resp == SAS_TASK_COMPLETE &&
+ task->task_status.stat == TMF_RESP_FUNC_SUCC) {
+ res = TMF_RESP_FUNC_SUCC;
+ break;
+ }
+
+ if (task->task_status.resp == SAS_TASK_COMPLETE &&
task->task_status.stat == SAS_DATA_UNDERRUN) {
/* no error, but return the number of bytes of
* underrun
--
1.9.1
next prev parent reply other threads:[~2016-08-10 20:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 13:19 [PATCH 0/8] hisi_sas internal abort support John Garry
2016-08-10 13:19 ` [PATCH 1/8] hisi_sas: add internal abort core code John Garry
2016-08-21 0:44 ` zhangfei
2016-08-22 7:50 ` John Garry
2016-08-10 13:19 ` [PATCH 2/8] hisi_sas: for internal abort in hisi_sas_dev_gone() John Garry
2016-08-10 13:20 ` [PATCH 3/8] hisi_sas: add internal abort to hisi_sas_abort_task() John Garry
2016-08-10 13:20 ` [PATCH 4/8] hisi_sas: add prep_abort_v2_hw() John Garry
2016-08-10 13:20 ` [PATCH 5/8] hisi_sas: add v2 hw slot complete internal abort support John Garry
2016-08-10 13:20 ` [PATCH 6/8] hisi_sas: fail tmf task prep when port detached John Garry
2016-08-10 13:20 ` John Garry [this message]
2016-08-10 13:20 ` [PATCH 8/8] hisi_sas: update version to 1.6 John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470835205-65684-8-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®