From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753786AbcHJSwG (ORCPT ); Wed, 10 Aug 2016 14:52:06 -0400 Received: from broadband.actcorp.in ([106.51.130.53]:5885 "EHLO arvind-ThinkPad-Edge-E431" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752591AbcHJSu4 (ORCPT ); Wed, 10 Aug 2016 14:50:56 -0400 X-Greylist: delayed 2399 seconds by postgrey-1.27 at vger.kernel.org; Wed, 10 Aug 2016 14:50:55 EDT From: Arvind Yadav To: broonie@kernel.org, galak@kernel.crashing.com Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Arvind Yadav Subject: [v.1] spi : spi-fsl :- Error check if cpm_muram_alloc fails and return Date: Wed, 10 Aug 2016 23:04:52 +0530 Message-Id: <1470850492-6606-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cpm_muram_alloc can fail so the returned value should be checked. Signed-off-by: Arvind Yadav --- drivers/spi/spi-fsl-cpm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/spi/spi-fsl-cpm.c b/drivers/spi/spi-fsl-cpm.c index 8f7b26e..1362e2d 100644 --- a/drivers/spi/spi-fsl-cpm.c +++ b/drivers/spi/spi-fsl-cpm.c @@ -258,6 +258,9 @@ static unsigned long fsl_spi_cpm_get_pram(struct mpc8xxx_spi *mspi) /* QE but with a dynamic pram location? */ if (mspi->flags & SPI_QE) { pram_ofs = cpm_muram_alloc(SPI_PRAM_SIZE, 64); + if (IS_ERR_VALUE(pram_ofs)) + return pram_ofs; + qe_issue_cmd(QE_ASSIGN_PAGE_TO_DEVICE, mspi->subblock, QE_CR_PROTOCOL_UNSPECIFIED, pram_ofs); return pram_ofs; @@ -269,9 +272,13 @@ static unsigned long fsl_spi_cpm_get_pram(struct mpc8xxx_spi *mspi) if (mspi->flags & SPI_CPM2) { pram_ofs = cpm_muram_alloc(SPI_PRAM_SIZE, 64); + if (IS_ERR_VALUE(pram_ofs)) + goto error_pram; + out_be16(spi_base, pram_ofs); } +error_pram: iounmap(spi_base); return pram_ofs; } -- 2.7.4