mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Romell <danielromell@gmail.com>
To: a.zummo@towertech.it
Cc: alexandre.belloni@free-electrons.com, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org, daro@hms.se, jao@hms.se,
	mago@hms.se
Subject: [PATCH 0/2] bq32000 fixes
Date: Thu, 11 Aug 2016 11:59:13 +0200	[thread overview]
Message-ID: <1470909555-9226-1-git-send-email-daro@hms.se> (raw)

Hi all,

This is a couple of patches for the bq32000 RTC.

The first one is purely cosmetic, fixing a case where the wrong mask (but
correct value) was used when reading a register value.

The second patch adds a check for a failure flag in the read function. If the
register contents can't be trusted, an error is returned instead.
The patch also removes some code in the probe function that would clear the
failure flag without resolving the error condition. The error is now only
cleared when writing a new time to the RTC.

Jan Östlund (2):
  rtc: bq32k: Use correct mask name for 'minutes' register.
  rtc: bq32k: Fix handling of oscillator failure flag

 drivers/rtc/rtc-bq32k.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

--
2.7.4

             reply	other threads:[~2016-08-11 10:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11  9:59 Daniel Romell [this message]
2016-08-11  9:59 ` [PATCH 1/2] rtc: bq32k: Use correct mask name for 'minutes' register Daniel Romell
2016-08-11  9:59 ` [PATCH 2/2] rtc: bq32k: Fix handling of oscillator failure flag Daniel Romell
2016-08-11 10:15   ` Alexandre Belloni
2016-08-11 11:31 ` [PATCH v2 0/2] bq32000 fixes Daniel Romell
2016-08-11 11:31 ` [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register Daniel Romell
2016-08-11 13:42   ` Alexandre Belloni
     [not found]     ` <5b6636b7-ff29-458b-b566-4b97e401b794@googlegroups.com>
2016-08-11 21:13       ` [rtc-linux] " Alexandre Belloni
2016-08-15  7:10   ` Jan Östlund
2016-08-11 11:31 ` [PATCH v2 2/2] rtc: bq32k: Fix handling of oscillator failure flag Daniel Romell
2016-08-15  7:10   ` Jan Östlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470909555-9226-1-git-send-email-daro@hms.se \
    --to=danielromell@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=daro@hms.se \
    --cc=jao@hms.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mago@hms.se \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®