From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: peterz@infradead.org
Cc: mingo@redhat.com, alexander.shishkin@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/3] perf/core: Enabling mapping of the stop filters
Date: Thu, 11 Aug 2016 13:47:23 -0600 [thread overview]
Message-ID: <1470944843-7575-4-git-send-email-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <1470944843-7575-1-git-send-email-mathieu.poirier@linaro.org>
At this time function perf_addr_filter_needs_mmap() will _not_
return true on a user space 'stop' filter. But stop filters
needs exactly the same kind of mapping that range and start
filters get.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
kernel/events/core.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 463235ffc39c..b5022836649a 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6553,15 +6553,6 @@ got_name:
}
/*
- * Whether this @filter depends on a dynamic object which is not loaded
- * yet or its load addresses are not known.
- */
-static bool perf_addr_filter_needs_mmap(struct perf_addr_filter *filter)
-{
- return filter->filter && filter->inode;
-}
-
-/*
* Check whether inode and address range match filter criteria.
*/
static bool perf_addr_filter_match(struct perf_addr_filter *filter,
@@ -7781,7 +7772,11 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
list_for_each_entry(filter, &ifh->list, entry) {
event->addr_filters_offs[count] = 0;
- if (perf_addr_filter_needs_mmap(filter))
+ /*
+ * Adjust base offset if the filter is associated to a binary
+ * that needs to be mapped.
+ */
+ if (filter->inode)
event->addr_filters_offs[count] =
perf_addr_filter_apply(filter, mm);
--
2.7.4
prev parent reply other threads:[~2016-08-11 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 19:47 [PATCH V3 0/3] perf/core: Miscellaneous fix for address filtering Mathieu Poirier
2016-08-11 19:47 ` [PATCH V3 1/3] perf/core: Fixing filename for start/stop filters Mathieu Poirier
2016-08-11 19:47 ` [PATCH V3 2/3] perf/core: Update filter only on executable mmap Mathieu Poirier
2016-08-11 19:47 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470944843-7575-4-git-send-email-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®