From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932206AbcHOAhI (ORCPT <rfc822;w@1wt.eu>);
	Sun, 14 Aug 2016 20:37:08 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47018 "EHLO
	out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751015AbcHOAhG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 14 Aug 2016 20:37:06 -0400
X-Sasl-enc: JrxLySawVQslw7wNzYfRDhxClW46XdEG8+CStlVzuqhd 1471221423
Message-ID: <1471221412.27272.76.camel@aj.id.au>
Subject: Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs
From: Andrew Jeffery <andrew@aj.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>, Joel Stanley <joel@jms.id.au>,
        Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Russell King <linux@armlinux.org.uk>, Jeremy Kerr <jk@ozlabs.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Mon, 15 Aug 2016 10:06:52 +0930
In-Reply-To: <1471049894.12231.41.camel@kernel.crashing.org>
References: <1468994313-13538-1-git-send-email-andrew@aj.id.au>
	 <1468994313-13538-3-git-send-email-andrew@aj.id.au>
	 <CACRpkdZ0p+jNHBV1AqhVWQ2Q8RRrHVfsAz3XU3_+f6My22=Zxg@mail.gmail.com>
	 <1470962022.27272.68.camel@aj.id.au>
	 <CACRpkdaN=wR4amskqMapTJzaTTMJZe2EQWRnyLMQkq_zuhr2eA@mail.gmail.com>
	 <1471049894.12231.41.camel@kernel.crashing.org>
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-Kkmm5pzJ9XyCVSXgcQ3s"
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--=-Kkmm5pzJ9XyCVSXgcQ3s
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2016-08-13 at 10:58 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2016-08-12 at 15:18 +0200, Linus Walleij wrote:
> >=20
> > I would probably prefer that option (introduce another field)
> > but you should make the overall decision, it's no strong opinion
> > from my side.
> >=20
> > >=20
> > > Would it be acceptable to document that requirement?
> It might make it a bit less nasty (and easier to change later on
> if necessary) to use some kind of:
>=20
> 	bool ast_signal_is_gpio(...)
>=20
> And stick the strcmp in there.

Yep, I'll do so for v2.

Cheers,

Andrew
--=-Kkmm5pzJ9XyCVSXgcQ3s
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCgAGBQJXsQ6kAAoJEJ0dnzgO5LT5aNgP/3haTd+82bDoeVfUYU6v9yNk
FRY+AdbZDoZcD0szs62isNzp6OxmmUpzgKoP32WVZ1ly6YnUjqNFXGytiQYdjoeN
qxexicf56ICRC+KIevpQPFOk72Jyifj2e0YWFDAc3OLrEfd9wan/1kfvr06cb9PE
GL+TraBA9YWQ3yo7S0KirAYbY4uvaM63vJ7YcrxeoazU6l2A5wh+k+a1cXp7LXdD
llfdnc+2/v8RAfon+nSm0MYBEa6AQJoUAEdE3z+9+k/VfLNzMpqTDFesvEMXfIAd
UOLWXaYEg76wrH39gj2QDPCg112PgxjVGmbz4lRtrddzXU7/umtVbYWudNOOQtUV
r28Lky6RlmQsZZ7we9hlbI8oqr8whJTmVXUVzADklzYLxdXSNYY8gFbZ7QyTti4y
NNPvmHGhMVI5MtJ5zU+7kGc66qn4H3GIBfWjsRITPr14GCaz3DDi5Sq10Ui9PMki
bU87q+3326woIH4IKZB+T4RyppmHRoRqvlDwVawukyIKgGP3f4uPbJ1H5YrMYNdV
1kb0Z3o+1+NRgSPIWJeVrHK0S9kCw+fBtjm79Q/emxvP4v45R5313UdRP+cqCkUT
PcqUbXWzcOmBFdaHVADEpxVm7HhSdEkle7/5mBthdC8Vba2+PgmpXZwq6kK35SfW
lhU5QWdrdkJ/W89kUV+k
=5CeO
-----END PGP SIGNATURE-----

--=-Kkmm5pzJ9XyCVSXgcQ3s--