From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbcHOISI (ORCPT ); Mon, 15 Aug 2016 04:18:08 -0400 Received: from mail.tricorecenter.de ([217.6.246.34]:57123 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbcHOISG (ORCPT ); Mon, 15 Aug 2016 04:18:06 -0400 From: Teresa Remmet To: Jyri Sarha , Tomi Valkeinen Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: tilcdc: Fix check for remote port parent Date: Mon, 15 Aug 2016 10:16:28 +0200 Message-Id: <1471248988-13322-1-git-send-email-t.remmet@phytec.de> X-Mailer: git-send-email 1.9.1 X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 15.08.2016 10:18:03, Serialize by Router on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 15.08.2016 10:18:03, Serialize complete at 15.08.2016 10:18:03 X-TNEFEvaluated: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In function tilcdc_get_external_components the check for the remote port parent is not correct. We need a '||' instead of an '&&'. Signed-off-by: Teresa Remmet --- There has been send out a different version of this patch about a year ago. But there was no feedback at all. Please apply one of the solutions. https://patchwork.kernel.org/patch/6596441/ Teresa drivers/gpu/drm/tilcdc/tilcdc_external.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.c b/drivers/gpu/drm/tilcdc/tilcdc_external.c index 03acb4f..ceba712 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_external.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_external.c @@ -145,7 +145,7 @@ int tilcdc_get_external_components(struct device *dev, struct device_node *node; node = of_graph_get_remote_port_parent(ep); - if (!node && !of_device_is_available(node)) { + if (!node || !of_device_is_available(node)) { of_node_put(node); continue; } -- 1.9.1