From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbcHOKml (ORCPT ); Mon, 15 Aug 2016 06:42:41 -0400 Received: from foss.arm.com ([217.140.101.70]:39770 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbcHOKmk (ORCPT ); Mon, 15 Aug 2016 06:42:40 -0400 From: Will Deacon To: linux-kernel@vger.kernel.org Cc: mark.rutland@arm.com, Will Deacon , Peter Zijlstra Subject: [PATCH] perf/core: Don't pass PERF_EF_START to the PMU ->start callback Date: Mon, 15 Aug 2016 11:42:45 +0100 Message-Id: <1471257765-29662-1-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PERF_EF_START is a flag to indicate to the PMU ->add callback that, as well as claiming the PMU resources required by the event being added, it should also start the PMU. Passing this flag to the ->start callback doesn't make sense, because ->start always tries to start the PMU. Remove it. Cc: Peter Zijlstra Signed-off-by: Will Deacon --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 1903b8f3a705..b11504376af7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2455,7 +2455,7 @@ static int __perf_event_stop(void *info) * while restarting. */ if (sd->restart) - event->pmu->start(event, PERF_EF_START); + event->pmu->start(event, 0); return 0; } -- 2.1.4