From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753350AbcHOQ07 (ORCPT ); Mon, 15 Aug 2016 12:26:59 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:53162 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbcHOQ06 (ORCPT ); Mon, 15 Aug 2016 12:26:58 -0400 From: Colin King To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Jiri Olsa , Pekka Enberg , Wang Nan Cc: linux-kernel@vger.kernel.org Subject: [PATCH] perf hists browser: remove superfluous null check on map Date: Mon, 15 Aug 2016 17:25:43 +0100 Message-Id: <1471278343-14999-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 2.8.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King map is being already checked if it is null at the start of do_zoom_dso, so the second subsequent check is superfluous and can be removed. Signed-off-by: Colin Ian King --- tools/perf/ui/browsers/hists.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 13d4143..8d72939 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -2418,8 +2418,6 @@ do_zoom_dso(struct hist_browser *browser, struct popup_action *act) browser->hists->dso_filter = NULL; ui_helpline__pop(); } else { - if (map == NULL) - return 0; ui_helpline__fpush("To zoom out press ESC or ENTER + \"Zoom out of %s DSO\"", __map__is_kernel(map) ? "the Kernel" : map->dso->short_name); browser->hists->dso_filter = map->dso; -- 2.8.1