From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753668AbcHPV1c (ORCPT ); Tue, 16 Aug 2016 17:27:32 -0400 Received: from mail-db5eur01on0047.outbound.protection.outlook.com ([104.47.2.47]:57344 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753087AbcHPV1a (ORCPT ); Tue, 16 Aug 2016 17:27:30 -0400 X-Greylist: delayed 35977 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Aug 2016 17:27:29 EDT Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; From: Liav Rehana To: CC: , , , , , Liav Rehana Subject: [PATCH] ARC: Change ld.as instruction to regular ld. Date: Tue, 16 Aug 2016 10:55:35 +0300 Message-ID: <1471334135-21801-1-git-send-email-liavr@mellanox.com> X-Mailer: git-send-email 1.7.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22516.005 X-TM-AS-Result: No--4.337600-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(50466002)(586003)(7846002)(19580405001)(8676002)(8936002)(81166006)(81156014)(50986999)(551984002)(4326007)(4001430100002)(48376002)(19580395003)(2906002)(356003)(106466001)(33646002)(11100500001)(189998001)(87936001)(5003940100001)(47776003)(92566002)(77096005)(626004)(305945005)(49486002)(110136002)(36756003)(2351001)(86362001)(229853001)(107886002)(50226002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB1871;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:mail13.mellanox.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD017;1:v9vhA1CJlegNw7v07N8xwC1zDNUj+9TzcfKnsaXl8xk6zQBpQZLVXiVCD0eIjqxt8nCqlUgC4niI3oCPeUYvhHbUz0JTC7qC5ERKsDi2DZu+8z3QxnTlGXdlQn8EFgwSJ98+1JQWTJ3OUHJVIZw48ioVzvEGUufkeB6ntIqWJ+MqeXKpFO8Yptah+PJ66MnJWeapvWroRdeSpr5jQ6p9OVHua/KVgb+Hs57uoXx1WsFawc9jbSgKRHQDOxRM8ZlZkrMx2NGEd/ti68eXnciEoKDqh9VE2/Uta7IYO+7CrPwMC/wXshem2dARwpt7R1Mb+zAjFW7ucscgx7pb6/hxP0xXcGQeTnSJKv8/29r/3FQvpQNqNnY0kj+lHDZKuExiW/KhSrpPx389ueTBZBTkgl2pdP4vqpGp1YXfEYwW1xQgVCyifCGRKKdQelEkorm1V8NdGbEC5cVKS3OhRERIFAGYKynZ2lNciMARBdyXFUFcFefV9mtoQh43Xb86T4/nOcp12R2K/OCw7BGJYDXftRo9a3ZLAYbOq8dLW7fEOOY= X-MS-Office365-Filtering-Correlation-Id: 67ac89c0-8e1d-439a-9c13-08d3c5aadfbf X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1871;2:yeYSP7J00C5/nyoBTHzZH5cru3/yODBB6nLWSCv/GuyTiRl+cMy/VxSXEmZY+9H4kyVyFhvlTCSPbxrQiXFjjU0KFNUC1ZbLMuOaWqHQX6ulUjFlQEZm3OgYbI9QrWyznTnD++nUkTP4frpweaVTFLNpaURtA3Qemt4ucKk3rWSrMjgx1KhlDCr3KOZr1Weg;3:CzR6WhY5ysD/AExgd4TbWX1omCXxjzt374SgF/eFMHWc3f8W8zH6X9ZxgDcI0F9dFiqJ4rJJxAY/4CIzgKMuGtr+AgBySCcwiHPvHiG9PhKy6/5ko7/kNgvF1rFj+CHgGWSHVf5cCxxO13y2ofVaA764H/ZQcfmN6O58DF4gZLPxcYvR0oMvbpEXK72aho66Nnm8YkquirAElfDBnpNVssPq773Q6dwAbm5nAhhdyZbJIuQUJGbaZytsv8OW3Zi2ttmXBWzf5vjLdIviIstL2Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:VI1PR05MB1871; X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1871;25:50gFeNw77003IQcwGgTgAbJQx1E8zwbAtZuKDoOQZB0+kVcPDe2kx917ihNOTq1pffoW/l7/DO9Z4L8HL+MFAb1aLBfrB5u3sWF65kwLjSS2ZGEtiLGQvL41A/yXAC3yJytHTcfolx0su5Gw8coHu4g6Sefk0GgB1wl6pM8vbmBMR2Xp+uNcMbZ8lm1U1xR+oDstXRf6NV4fO+H040EJ9O3DNCwXCwyj7J8OhPKjXgesbFK8X2zYoNHsqPv61simdMaLDiZTqacvnfDo5eRu212JS/tFPUg+4hPThwmM57ztYz2XCDaEMjio61xM0M1HHUG9rZN59eXr8B7SgWp6Dcwz9QBUEUnJC9iGfskUDnASOU66oiPS4BxYZZ0DsCnCA+Ng4muhURDDgBmi4WbuGVd0Q4hP1kcZ/3t9IwP3c/KHBLAhLUXklOWTWXNHEmqPeBQXL1Of6tJ9xaC8jM1K215DNd09h3hWKSXO1ucP9yt5T052mR2VP9Y1KNk1CxzaBXheu9i9ehODtJRiX6R4GIYwvgXy+fH8BV+ZxvxIeates/rRii1v0dTLsxViPscytFzRd+tITQIzrWxAef/rW51hiQSpHjAoHjWJ0HyDehowUM5UanTHdrtKK7nSRKJZJ8fAb38aSRdQE8QVYeigfi5lETsJqOKSipmT7RrzSt0GOt3r7ncDKjZTWlpAHcRmJmfsstIqcpvJaSXQ34iHMLF7u1SC5TToXH9hsQ8eLERvHz0ufIpw2u503WJ3wgJCbcQHFdrb8IV+tsUhDcoTLQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1871;31:mEsDdT0p80Kw0kera/Wo/1Q1KTax8eOA8Hj6KcnAsk7Rwe9zl0XEtWeng5zR+L7uBemmzCxFVWMxvyPth2/h6EzUfsQ/7vlRqwLoW5Yw6PpazDejoR4k7P+0ma4KxxKDi9bOgghX8mYbI3U+xzwWeTcyTisOwIY18utmi+itI0t0157vrow5aQZbz7WdXx6WYWE7SW+Yg3TPxIHqsejIkRwagEu2BrSXxamx/3s05uU=;20:c1hz0ihTj+pjMpQnplTIUE9IDqw+e5P7Tt5GvYbIouFhTgJkS05AesK/SbaK4xJfDQycrgYkcRFftsjcCjIJAYI+hl8Bdktsx9M4CU4l3iOfhIrCYC0z6eG0F/TfFVV/uNJj7BpRQ/Y0RaC2wlk23TfV6EN7tLX7RiSKufJzkd/xPFKyW3Z6egtb89WxK+GHJLPkXyUN40WFaZgKN7AvrNLcgvjFrn2OzS+I6/lwVJGUi5l7pJBlJ3KrUX5az1eTivhSCd4SS4DIqh/8p/TLtXYW0GrPGbdDVPKXvNr0LIaeejtx4WJpfDqyyKiNq9jD/xiTZY77vfsAsD6lKba6VaIAK1/cFGPr/8gcvqwtz3sYqglqLw1OGVxEg5kHkgOoQblnp/rpdPoYJmtEsloSs1DyJfTpiwxun/+ATFSrauSoK/0tonNi49onLsfVJ+mE7RNrfEKattpW8esPv7WZ/FMSTFH8PbYe7Yf+QhZMHw5FsZOWkN7zzbzlk9aQUEtp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(13018025)(13016025)(5005006)(10201501046)(3002001)(6055026);SRVR:VI1PR05MB1871;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB1871; X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1871;4:PPXrZI5iLW0QBdk4vFs1M3ySy2JonJzDWGMMgK7qJ7U9Ie2zcHnaUgvIUeVGq4Y/KC5DGHi7mL2xDgA3MVMLdBjOaoC0uV7Mmzk7vECYz/5oUc2v96JnMw0N2YWkhPivczeXXhKNRFqBEEJXKRyFHpzyEUWsMChngw4uUtjz0mMyzj2K5Ocs4qfdq9jdkMO0BGJF+DGgANf3ZhwzIqajuXHQ2Z1cGlWL6Kqb/rNWdyFOqpMydk2kR54vQ610Cp05oya9I0Fkwh6Cuqz8gA7bX78MzazulYvCrh3ow0gSAwMt4ZnTrFhowpaDy+P09N9gDVsBbAm1udj2vvhgWkITlnYSGrkmD6vXxByNRHqgLOHAfSuRHJs9/lj7bZrTUBV/cy/TMxKPQN/9TP3J0USIEdRXd8AWN2Hfmuc0N8cfyv2bvI6g3HincIKE47XNbpAo X-Forefront-PRVS: 0036736630 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR05MB1871;23:mVGeu4C8x6f7nl1LiTLFeeyOtjWZK9YG8aZmSnkEc?= =?us-ascii?Q?K/hcigT0X1lJetayiWDgusOHHbimrOkrbtPczlmungo4a2s/Qnb0/O1k/mfM?= =?us-ascii?Q?PwZ4qcLViSe259SvMe6dihlSFGSL6NnDFSTs2f3gRpjF5lOk7Dv274CgmjCX?= =?us-ascii?Q?+1je2L/x5nQ7DG1Dc0OybaCf53+Ocv7E0SQJouOxCOLYleXBdpCpuHKHEeAY?= =?us-ascii?Q?CdT71egUdsMmZNumhcfC0sM2RX9Cb9SuM13eJqCiVsJzwTvyLLTrwr1bHWj6?= =?us-ascii?Q?UJZxgSQXWJfVznj39OubGxi6PUBhtds0fUHFX1hQQE1Se6sf5bXbWB5qeWc/?= =?us-ascii?Q?sVqakY0TR9NdYQeGa9R/3A3/Cqd2qBpqvqEIrm91h7PQrmcwj5EWxxBHbsRX?= =?us-ascii?Q?utnw4vN4x1YDMrxWmImHb/jMqk5kPvUuDTV56NpdFERKf8VA9ITG6R+DN0vg?= =?us-ascii?Q?rsxa7LrKBwBCbibIXmCJX4wzJhiN0kt5gH9jeuWxQWTzLhIwVhNh+ama9Afp?= =?us-ascii?Q?LDHvyQ10pn4M7Qi8zZ11Vhy23qfUVjQtfhM1TEEKN6HDcwmYx+TF63pf7MZS?= =?us-ascii?Q?qpl7zsDN2gV+YvxgdY+iZT11l4Xe8mItNKZot/b4sH1enIt8OTqe+aB584K4?= =?us-ascii?Q?AU0dlK/kzz3Eh5gs320/+3yxqKs1VeRZURjIEqf7aUDIVkKTKWTcFUrYOVdI?= =?us-ascii?Q?t4SAHC8qUC5HFrC6vQYj72AHTnyJotREkKRR3nM0LfGUjdzsZTmGq5BHPd0G?= =?us-ascii?Q?/E7VrrTZqs9K34oyTiPpDy2FHb3+WtnnrnDYMvL/7LlksB4EOpSGWIm2NcF8?= =?us-ascii?Q?2EBORi0qpY369PWx5NdazkBzBaSBzylqxt+LeqnPti5jMWWt6DsuV3cLek2Q?= =?us-ascii?Q?lpJYoEEfGftlsgqslmPObYY7U9szzWi8ZZksKju4YK/wxljH4pveZyNVf16D?= =?us-ascii?Q?ztVoa0FubZe8fI/ebLqWdGJJksAeqddqhHeopzR03eyWnp1/lynCHX3mHRJ9?= =?us-ascii?Q?91PMN/E7Lq3HS5r7ZTV7bhD0UBmD03xDhJruO/mPDEEB6kJSBYNHUQUs1kUL?= =?us-ascii?Q?Odw9UM=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1871;6:rnlYxP6QyxX8et4isPnhrh7gEq0ADx3PHiq8Pnlf4h/Juhy2uYzAHIDEgzxEqNBmxjZnWp9YECylFR38LKI6hld4x2SEqjFQlnXIixoOXcjxad8DMdNstVt1hpuWB1d9POQfI+S5QVbyHa7SbeAjOPU/aEky9VwGb6hWanw8ltW3QRDk7CqBiiO/WKCuBQRHj5BKz1YD/KkoTaSiIQ02Z42Skn5LWU7Eb6PoRWohJCT0CYjnv0kO00h/cZUm7n6UiM9CNve903g48dXxQq7rMGil4S2GtlS5AqjcH9WpoHR+wIr3r4XJVf9kNOO0gokMxO8QpHntwxBtBt46gGKYkQ==;5:k6KE+9SznAmWh/Ku5rux+mCjqcxqatZts3NseXGjvGQCyFRDTsS4dVqY/moAHsCU+8zB7fHujvislgqnBdZkWO+IBKgwLzxW4vkQ+g3ivS1zu+atV6LhCIUz2Eqbbq+/Pk0zL/X1HHn+RIlC5DNFuA==;24:7patrlBcyU6pVorcP1YLRG4UNUkt1BUNaKGAsoqwz/6yE87hMUxeDbxmRuY2T2ij0YIQTal9ThS+eGNxbVpiP8ESMpLa/ZCeKDhWoOjR6Ks=;7:71LzIkwY9Zp56BdxiMhtyv4GAQikWk+6NrY6r0d0DXKrg/AYWpAbW2xbeSNZXhrMhI0n5U1FXck8BPHq0Ca+A0tVCGgjHy1luMaNZKUePOn++JLMAWyJ3Z4t4tcEvNFq0VaEbCvseoPVMixl7+IAM4bYD+7XUNsr5OB629lg6W9lGVFEfaCvTUzBurQGU1a4JzH/CDiFghXu9pll4kxLNwd4UVhYHRhVdFG8bYBN7xRsEBUBrr9WOAmitpjkgr9p SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2016 07:56:47.5864 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1871 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liav Rehana The instruction ld.as takes as operands a base address and an offset, and doesn't access the sum of these two, but the sum of the base address and a shifted version of the offset. This isn't what we want in that case, since it causes a bug during the push and pop of r25, since his actual offset is given during resume_user_mode_begin. Thus, the use of ld solves this problem. Signed-off-by: Liav Rehana --- arch/arc/include/asm/entry.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/include/asm/entry.h b/arch/arc/include/asm/entry.h index 337ab6d..9d8f85d 100644 --- a/arch/arc/include/asm/entry.h +++ b/arch/arc/include/asm/entry.h @@ -138,7 +138,7 @@ #ifdef CONFIG_ARC_CURR_IN_REG ; Retrieve orig r25 and save it with rest of callee_regs - ld.as r12, [r12, PT_user_r25] + ld r12, [r12, PT_user_r25] PUSH r12 #else PUSH r25 @@ -194,7 +194,7 @@ ; SP is back to start of pt_regs #ifdef CONFIG_ARC_CURR_IN_REG - st.as r12, [sp, PT_user_r25] + st r12, [sp, PT_user_r25] #endif .endm -- 1.7.1