From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932489AbcHPNjY (ORCPT ); Tue, 16 Aug 2016 09:39:24 -0400 Received: from smtp.ispras.ru ([83.149.199.79]:34848 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932460AbcHPNjW (ORCPT ); Tue, 16 Aug 2016 09:39:22 -0400 From: Pavel Andrianov To: Mugunthan V N Cc: Pavel Andrianov , "David S. Miller" , Antonio Quartulli , Felipe Balbi , Florian Westphal , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vaishali.thakkar@oracle.com, ldv-project@linuxtesting.org Subject: [PATCH] smc91c92_cs : add a spinlock to avoid race condition Date: Tue, 16 Aug 2016 16:39:06 +0300 Message-Id: <1471354746-27110-1-git-send-email-andrianov@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org smc_reset may be executed in parallel with timer function media_check. To avoid data race in smc_set_xcvr a spinlock was added. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Pavel Andrianov --- drivers/net/ethernet/smsc/smc91c92_cs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc91c92_cs.c b/drivers/net/ethernet/smsc/smc91c92_cs.c index db3c696..69d865c 100644 --- a/drivers/net/ethernet/smsc/smc91c92_cs.c +++ b/drivers/net/ethernet/smsc/smc91c92_cs.c @@ -1637,6 +1637,7 @@ static void smc_reset(struct net_device *dev) unsigned int ioaddr = dev->base_addr; struct smc_private *smc = netdev_priv(dev); int i; + unsigned long flags; netdev_dbg(dev, "smc91c92 reset called.\n"); @@ -1647,6 +1648,7 @@ static void smc_reset(struct net_device *dev) outw(RCR_SOFTRESET, ioaddr + RCR); udelay(10); + spin_lock_irqsave(&smc->lock, flags); /* Clear the transmit and receive configuration registers. */ outw(RCR_CLEAR, ioaddr + RCR); outw(TCR_CLEAR, ioaddr + TCR); @@ -1699,6 +1701,7 @@ static void smc_reset(struct net_device *dev) SMC_SELECT_BANK(2); outw((IM_EPH_INT | IM_RX_OVRN_INT | IM_RCV_INT) << 8, ioaddr + INTERRUPT); + spin_unlock_irqrestore(&smc->lock, flags); } /*====================================================================== -- 2.7.4