From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbcHPNx4 (ORCPT ); Tue, 16 Aug 2016 09:53:56 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33941 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753705AbcHPNxx (ORCPT ); Tue, 16 Aug 2016 09:53:53 -0400 From: LABBE Corentin To: alexandre.belloni@free-electrons.com, paul.gortmaker@windriver.com, nicolas.ferre@atmel.com Cc: linux-kernel@vger.kernel.org, LABBE Corentin Subject: [PATCH] memory: atmel-sdramc: fix a possible NULL dereference Date: Tue, 16 Aug 2016 15:53:18 +0200 Message-Id: <1471355598-11853-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.7.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so cause a NULL pointer dereference later. For fixing this problem, we use of_device_get_match_data(), this will simplify the code a little by using a standard function for getting the match data. Signed-off-by: LABBE Corentin --- drivers/memory/atmel-sdramc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/memory/atmel-sdramc.c b/drivers/memory/atmel-sdramc.c index 53a341f..12080b0 100644 --- a/drivers/memory/atmel-sdramc.c +++ b/drivers/memory/atmel-sdramc.c @@ -53,12 +53,10 @@ static const struct of_device_id atmel_ramc_of_match[] = { static int atmel_ramc_probe(struct platform_device *pdev) { - const struct of_device_id *match; const struct at91_ramc_caps *caps; struct clk *clk; - match = of_match_device(atmel_ramc_of_match, &pdev->dev); - caps = match->data; + caps = of_device_get_match_data(&pdev->dev); if (caps->has_ddrck) { clk = devm_clk_get(&pdev->dev, "ddrck"); -- 2.7.3