From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835AbcHQA1n (ORCPT ); Tue, 16 Aug 2016 20:27:43 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:42445 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbcHQA1l (ORCPT ); Tue, 16 Aug 2016 20:27:41 -0400 Message-ID: <1471391462.13300.56.camel@decadent.org.uk> Subject: Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of jumps From: Ben Hutchings To: Florian Westphal Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Pablo Neira Ayuso , Greg Kroah-Hartman Date: Wed, 17 Aug 2016 00:51:02 +0100 In-Reply-To: <20160813203545.GB17154@breakpoint.cc> References: <20160813183048.GA17154@breakpoint.cc> <1471114295.13300.22.camel@decadent.org.uk> <20160813203545.GB17154@breakpoint.cc> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-9ARENKKQO5ot6KUgbfZ8" X-Mailer: Evolution 3.20.4-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 109.148.166.21 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-9ARENKKQO5ot6KUgbfZ8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2016-08-13 at 22:35 +0200, Florian Westphal wrote: > > Ben Hutchings wrote: > >=20 > > On Sat, 2016-08-13 at 20:30 +0200, Florian Westphal wrote: > > >=20 > > > >=20 > > > > > > > > Ben Hutchings wrote: > > > >=20 > > > > 3.16.37-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, = please let me know. > > > >=20 > > > > ------------------ > > > >=20 > > > > >=20 > > > > > >=20 > > > > > > > > > > > > From: Florian Westphal > > > >=20 > > > > commit 36472341017529e2b12573093cc0f68719300997 upstream. > > >=20 > > > [..] > > >=20 > > > >=20 > > > >=20 > > > > The extra overhead is negible, even with absurd cases. > > >=20 > > > Not true, the overhead is huge and increases restore time for > > > large rulesets from mere seconds to minutes, see > > >=20 > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi= t/?id=3Df4dc77713f8016d2e8a3295e1c9c53a21f296def > >=20 > > So do you think I should add that to this update or defer the netfilter > > changes to the next update? >=20 > Depends on what your focus is for 3.16. >=20 > If your focus is to better not break anything I would just drop > this patch and apply it for the next round with the fix > (f4dc77713f8016d2e8a3295e1c9c53a21f296def) on top once it had more > soak time. I thought there were more that depended on this one, but in fact dropping just this seems to work. =C2=A0So that's what I've done for now. Thanks. Ben. --=20 Ben Hutchings If at first you don't succeed, you're doing about average. --=-9ARENKKQO5ot6KUgbfZ8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXs6bmAAoJEOe/yOyVhhEJOMAQANXQ3Y+DGR+5WOl3hGgwwWmS lB2QoxX+F+SnRDPJQOL7biqarGiSJS1UQXBUsN8JRRXNCdpFgr4bl67mzHJLUe93 Si2Y1qEQknh8xqeGnhvr64/k/keaDRkzU8ygzd3f3DybQw2GDr0XjsyCkPgMg7LW NQ92GWgdOmlLJOJn6PtNqAQncPqcoirzd2bRmVCawc8BL6CCxccaclDl51W1DsNe AQVBsYro5R9o8kFDVBLmxrCtAmkV0DxbUu3NORe1br05Ja8RUYQaGhrAYFNjA1uK 8ZbFpcnpM6MxiOxao8eZi7LnuUuuOo7SLqMS2jt4NMChczipXvsu6GDbMshNal09 /bxW7QHAvuR3d5gAblxlCI1Cs83E6ROqIcWrOqyz/SHAAinfm7wkzg3x9Ip9GEF+ QHwPmK6pIEKSoBHcSiNGnHPdn+6KAwvndurl93CieUfa9v6dEN9wnOekA9OPmhGd fpIVgMihQ7uu5BFbh+Yv20GuQXZARQDAywQKu6aT2MuAGYMV361f+ZUPnkWFczF0 WHFbTQPt0fkGFffKN8D6CmptOdkpig89Vcw08lk9zv5eQtQK+cJ2sbBdkyESh+zd zC/TZ84qzfOSt8iBszDnbkmrir/yv2blDmrruO6F9qCf/NGghlI5McfRMZ+FnQvH xsYqLO/vkxIaNBMD0482 =FVNp -----END PGP SIGNATURE----- --=-9ARENKKQO5ot6KUgbfZ8--