From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752213AbcHQKBJ (ORCPT ); Wed, 17 Aug 2016 06:01:09 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:22778 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbcHQKBH (ORCPT ); Wed, 17 Aug 2016 06:01:07 -0400 X-AuditID: cbfec7f4-f796c6d000001486-80-57b435d43feb From: Andrzej Hajda To: Matt Fleming , linux-efi@vger.kernel.org (open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] efi: fix handling error value in fdt_find_uefi_params Date: Wed, 17 Aug 2016 12:00:40 +0200 Message-id: <1471428040-23463-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDJMWRmVeSWpSXmKPExsVy+t/xq7pXTLeEG0yYYGBxa905VouNM9az WrQ9vMVocXnXHDaLtUfuslv0vyxzYPPo2jCL0aNvyypGj8+b5AKYo7hsUlJzMstSi/TtErgy 1jUsZi6YyV6x7ttftgbGj6xdjJwcEgImEjvfNLJA2GISF+6tZ+ti5OIQEljKKPH0+jYmCKeJ SWL16vXMIFVsApoSfzffZAOxRQQqJGbN/M4CUsQssItR4s/NtWBFwgJuEpMXXgYbyyKgKjHn 4BvGLkYODl4BZ4mZywwgtslJnDw2mXUCI/cCRoZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmb GCFh8GUH4+JjVocYBTgYlXh4b1ptDhdiTSwrrsw9xCjBwawkwjvVZEu4EG9KYmVValF+fFFp TmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhgXsCl4PplrffB3xOmUOv6F2guv hjt17Tq+fO7FYCX9QiG9c+n3D+5ScVM7Fnnxhc/t9ud7tPWv3+F4vLd575xpkz0Pn9g2USFt 5RIzqbWJEzr6ZQ7sfxu10e5Ewd8Iv2nPbBz+zziQapx31/rh6/4jm15M/Xbx5Z/uWZz3wtfd Ez+1fv22eREc5UosxRmJhlrMRcWJAFRP7Qv/AQAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_get_flat_dt_subnode_by_name can return negative value in case of error. The problem has been detected using semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda --- drivers/firmware/efi/efi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index 5a2631a..7dd2e2d 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -657,9 +657,12 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname, } if (subnode) { - node = of_get_flat_dt_subnode_by_name(node, subnode); - if (node < 0) + int err = of_get_flat_dt_subnode_by_name(node, subnode); + + if (err < 0) return 0; + + node = err; } return __find_uefi_params(node, info, dt_params[i].params); -- 1.9.1