From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbcHQKWb (ORCPT ); Wed, 17 Aug 2016 06:22:31 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:34707 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcHQKWa (ORCPT ); Wed, 17 Aug 2016 06:22:30 -0400 From: Daniel Lezcano To: mingo@kernel.org Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Gregory CLEMENT , Stefan Roese , Ralph Sennhauser Subject: [PATCH 1/3] clocksource/drivers/time-armada-370-xp: Fix the clock reference Date: Wed, 17 Aug 2016 12:21:33 +0200 Message-Id: <1471429296-9053-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <57B439B0.8010901@linaro.org> References: <57B439B0.8010901@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gregory CLEMENT While converting the init function to return an error, the wrong clock was get. This lead to wrong clock rate and slow down the kernel. For example, before the patch a typical boot was around 15s after it was 1 minute slower. Fixes: 12549e27c63c ("clocksource/drivers/time-armada-370-xp: Convert init function to return error") Signed-off-by: Gregory CLEMENT Signed-off-by: Daniel Lezcano Tested-by: Stefan Roese Tested-by: Ralph Sennhauser --- drivers/clocksource/time-armada-370-xp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c index 20ec066..9872992 100644 --- a/drivers/clocksource/time-armada-370-xp.c +++ b/drivers/clocksource/time-armada-370-xp.c @@ -357,7 +357,6 @@ static int __init armada_xp_timer_init(struct device_node *np) struct clk *clk = of_clk_get_by_name(np, "fixed"); int ret; - clk = of_clk_get(np, 0); if (IS_ERR(clk)) { pr_err("Failed to get clock"); return PTR_ERR(clk); -- 1.9.1