From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753628AbcHQWEr (ORCPT ); Wed, 17 Aug 2016 18:04:47 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35285 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837AbcHQWEo (ORCPT ); Wed, 17 Aug 2016 18:04:44 -0400 From: Guenter Roeck To: Felipe Balbi Cc: Chandra Sekhar Anagani , Bruce Ashfield , Bin Gao , Pranav Tipnis , Heikki Krogerus , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Guenter Roeck Subject: [RFC PATCH v2 1/4] usb: typec: Do not check if connected when setting roles Date: Wed, 17 Aug 2016 15:04:33 -0700 Message-Id: <1471471476-53251-2-git-send-email-groeck@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1471471476-53251-1-git-send-email-groeck@chromium.org> References: <1471471476-53251-1-git-send-email-groeck@chromium.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The connection status can change after the connection status was checked. Leave it up to the driver to perform the necessary checks. Signed-off-by: Guenter Roeck --- v2: Rebased to v5 of Type-C class code drivers/usb/typec/typec.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/typec/typec.c b/drivers/usb/typec/typec.c index 52a0431253a8..fa0261dad3b7 100644 --- a/drivers/usb/typec/typec.c +++ b/drivers/usb/typec/typec.c @@ -785,9 +785,6 @@ current_data_role_store(struct device *dev, struct device_attribute *attr, return -EOPNOTSUPP; } - if (!port->connected) - return size; - ret = sysfs_strmatch(typec_data_roles, ARRAY_SIZE(typec_data_roles), buf); if (ret < 0) @@ -851,9 +848,6 @@ static ssize_t current_power_role_store(struct device *dev, return -EIO; } - if (!port->connected) - return size; - ret = sysfs_strmatch(typec_roles, ARRAY_SIZE(typec_roles), buf); if (ret < 0) return ret; -- 2.8.0.rc3.226.g39d4020