mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Elaine Zhang <zhangqing@rock-chips.com>
To: broonie@kernel.org
Cc: huangtao@rock-chips.com, zyw@rock-chips.com, xxx@rock-chips.com,
	jay.xu@rock-chips.com, linux-kernel@vger.kernel.org,
	Elaine Zhang <zhangqing@rock-chips.com>
Subject: [PATCH 0/1] regmap: drop cache if the bus transfer error
Date: Thu, 18 Aug 2016 17:01:55 +0800	[thread overview]
Message-ID: <1471510915-24838-2-git-send-email-zhangqing@rock-chips.com> (raw)
In-Reply-To: <1471510915-24838-1-git-send-email-zhangqing@rock-chips.com>

regmap_write
->_regmap_raw_write
-->regcache_write first and than use map->bus->write to wirte i2c or spi
But if the i2c or spi transfer failed, But the cache is updated, So if I use
regmap_read will get the cache data which is not the real register value.

Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
---
 drivers/base/regmap/regmap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 1f011f9d6dcb..369a4c3c933e 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -1497,6 +1497,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg,
 		ret = map->bus->write(map->bus_context, buf, len);
 
 		kfree(buf);
+	} else if (ret != 0 && !map->cache_bypass && map->format.parse_val) {
+		regcache_drop_region(map, reg, reg + 1);
 	}
 
 	trace_regmap_hw_write_done(map, reg, val_len / map->format.val_bytes);
-- 
1.9.1

  reply	other threads:[~2016-08-18  9:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  9:01 [PATCH 0/0] " Elaine Zhang
2016-08-18  9:01 ` Elaine Zhang [this message]
2016-08-18  9:42 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2016-08-18  6:43 Elaine Zhang
2016-08-18  6:43 ` [PATCH 0/1] " Elaine Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471510915-24838-2-git-send-email-zhangqing@rock-chips.com \
    --to=zhangqing@rock-chips.com \
    --cc=broonie@kernel.org \
    --cc=huangtao@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xxx@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®