mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Markus Heiser <markus.heiser@darmarIT.de>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Helen Mae Koike Fornazier <helen.koike@collabora.co.uk>,
	Antti Palosaari <crope@iki.fi>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH v5 09/12] [media] vivid: Local optimization
Date: Thu, 18 Aug 2016 16:33:35 +0200	[thread overview]
Message-ID: <1471530818-7928-10-git-send-email-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <1471530818-7928-1-git-send-email-ricardo.ribalda@gmail.com>

Avoid duplicated clamps when possible.

Suggested-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c b/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
index 7364ced09abc..ed37ae307cac 100644
--- a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
+++ b/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
@@ -916,14 +916,18 @@ static void precalculate_color(struct tpg_data *tpg, int k)
 		if (!ycbcr_valid)
 			color_to_ycbcr(tpg, r, g, b, &y, &cb, &cr);
 
+		y >>= 4;
+		cb >>= 4;
+		cr >>= 4;
 		if (tpg->real_quantization == V4L2_QUANTIZATION_LIM_RANGE) {
-			y = clamp(y, 16 << 4, 235 << 4);
-			cb = clamp(cb, 16 << 4, 240 << 4);
-			cr = clamp(cr, 16 << 4, 240 << 4);
+			y = clamp(y, 16, 235);
+			cb = clamp(cb, 16, 240);
+			cr = clamp(cr, 16, 240);
+		} else {
+			y = clamp(y, 1, 254);
+			cb = clamp(cb, 1, 254);
+			cr = clamp(cr, 1, 254);
 		}
-		y = clamp(y >> 4, 1, 254);
-		cb = clamp(cb >> 4, 1, 254);
-		cr = clamp(cr >> 4, 1, 254);
 		switch (tpg->fourcc) {
 		case V4L2_PIX_FMT_YUV444:
 			y >>= 4;
-- 
2.8.1

  parent reply	other threads:[~2016-08-19  6:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 14:33 [PATCH v5 00/12] Add HSV format Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 01/12] [media] videodev2.h Add HSV formats Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 02/12] [media] Documentation: Add HSV format Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 03/12] [media] Documentation: Add Ricardo Ribalda Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 04/12] [media] vivid: Code refactor for color encoding Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 05/12] [media] vivid: Add support for HSV formats Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 06/12] [media] vivid: Rename variable Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 07/12] [media] vivid: Introduce TPG_COLOR_ENC_LUMA Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 08/12] [media] vivid: Fix YUV555 and YUV565 handling Ricardo Ribalda Delgado
2016-08-18 14:33 ` Ricardo Ribalda Delgado [this message]
2016-08-18 14:33 ` [PATCH v5 10/12] [media] videodev2.h Add HSV encoding Ricardo Ribalda Delgado
2016-08-19 13:14   ` Hans Verkuil
2016-08-22  9:26     ` Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 11/12] [media] Documentation: Add HSV encodings Ricardo Ribalda Delgado
2016-08-18 14:33 ` [PATCH v5 12/12] [media] vivid: Add support for HSV encoding Ricardo Ribalda Delgado
2016-09-07  7:51 ` [PATCH v5 00/12] Add HSV format Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471530818-7928-10-git-send-email-ricardo.ribalda@gmail.com \
    --to=ricardo.ribalda@gmail.com \
    --cc=crope@iki.fi \
    --cc=helen.koike@collabora.co.uk \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=markus.heiser@darmarIT.de \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®