From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508AbcHSN3v (ORCPT ); Fri, 19 Aug 2016 09:29:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42476 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754871AbcHSN27 (ORCPT ); Fri, 19 Aug 2016 09:28:59 -0400 From: Benjamin Tissoires To: Jean Delvare , Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/10] i2c: i2c-smbus: fix return value of i2c_handle_smbus_host_notify() Date: Fri, 19 Aug 2016 15:27:40 +0200 Message-Id: <1471613262-20682-9-git-send-email-benjamin.tissoires@redhat.com> In-Reply-To: <1471613262-20682-1-git-send-email-benjamin.tissoires@redhat.com> References: <1471613262-20682-1-git-send-email-benjamin.tissoires@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 19 Aug 2016 13:27:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org schedule_work() returns a boolean (true on success, false if the work was already queued). This doesn't match the "negative number on error" return model that the function exports. Given that schedule_work() will always return true (we have an internal .pending check protected by a spinlock), just return false and ignore the return value of schedule_work(). Signed-off-by: Benjamin Tissoires --- new in v2 --- drivers/i2c/i2c-smbus.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c index 819e5f2..f6780de 100644 --- a/drivers/i2c/i2c-smbus.c +++ b/drivers/i2c/i2c-smbus.c @@ -357,7 +357,10 @@ int i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify, host_notify->pending = true; spin_unlock_irqrestore(&host_notify->lock, flags); - return schedule_work(&host_notify->work); + /* schedule_work is called if .pending is false, so it can't fail. */ + schedule_work(&host_notify->work); + + return 0; } EXPORT_SYMBOL_GPL(i2c_handle_smbus_host_notify); -- 2.5.5