From: Shuah Khan <skhan@linuxfoundation.org>
To: Roberto Ricci <io@r-ricci.it>
Cc: Thomas Renninger <trenn@suse.com>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/4] cpupower-idle-info.1: fix short option names
Date: Wed, 11 Mar 2026 18:39:57 -0600 [thread overview]
Message-ID: <1471739b-6809-42eb-9aaf-b0700315c5a1@linuxfoundation.org> (raw)
In-Reply-To: <abH7pF9p8KxAsHIE@desktop0a>
On 3/11/26 17:32, Roberto Ricci wrote:
> The cpupower-idle-info(1) man page describes '-f' as the short form of
> the '--silent' option and '-e' as the short form of the '--proc' option.
> But they are not correct:
>
> $ cpupower idle-info -f
> idle-info: invalid option -- 'f'
> invalid or unknown argument
> $ cpupower idle-info -e
> idle-info: invalid option -- 'e'
> invalid or unknown argument
>
> The short form of '--silent' is actually '-s' and the short form of
> '--proc' is actually 'o':
>
> cpuidle-info.c:
> {"silent", no_argument, NULL, 's'},
> {"proc", no_argument, NULL, 'o'},
>
> Fixes e7d85a934182d5bde1eea865169fbf2e0637a3ed ("cpupower: Add cpupower-idle-info manpage")
>
> Signed-off-by: Roberto Ricci <io@r-ricci.it>
It is odd that your patch v2s are showing up as responses.
Please send a proper patch so I can review - same comment
on the other 3 patches.
thanks,
-- Shuah
prev parent reply other threads:[~2026-03-12 0:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 19:20 [PATCH " Roberto Ricci
2026-03-11 20:41 ` Shuah Khan
2026-03-11 23:32 ` [PATCH v2 " Roberto Ricci
2026-03-12 0:39 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471739b-6809-42eb-9aaf-b0700315c5a1@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=io@r-ricci.it \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®