From: Nicholas Mc Guire <hofrat@osadl.org>
To: Jon Mason <jdmason@kudzu.us>
Cc: Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>,
Logan Gunthorpe <logang@deltatee.com>,
Arnd Bergmann <arnd@arndb.de>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH 1/2] ntb_transport: make DMA_OUT_RESOURCE_TO HZ independent
Date: Mon, 22 Aug 2016 18:51:35 +0200 [thread overview]
Message-ID: <1471884696-25558-1-git-send-email-hofrat@osadl.org> (raw)
schedule_timeout_* takes a timeout in jiffies but the code currently is
passing in a constant which makes this timeout HZ dependent, so pass it
through msecs_to_jiffies() to fix this up.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Problem found by coccinelle script
The below patch sets the timeout to 50ms - not clear what HZ setting was
assumed during design/testing, so this needs an ack by someone who knows
the driver and can confirm that 50ms is reasonable to wait on retries.
Patch was compile tested with: x86_64_defconfig + CONFIG_NTB=m,
CONFIG_NTB_TRANSPORT=m
Patch is against 4.8.0-rc2 (localversion-next is -next-20160822)
drivers/ntb/ntb_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index 8601c10..4eb8adb 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -257,7 +257,7 @@ enum {
#define NTB_QP_DEF_NUM_ENTRIES 100
#define NTB_LINK_DOWN_TIMEOUT 10
#define DMA_RETRIES 20
-#define DMA_OUT_RESOURCE_TO 50
+#define DMA_OUT_RESOURCE_TO msecs_to_jiffies(50)
static void ntb_transport_rxc_db(unsigned long data);
static const struct ntb_ctx_ops ntb_transport_ops;
--
2.1.4
next reply other threads:[~2016-08-22 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 16:51 Nicholas Mc Guire [this message]
2016-08-22 16:51 ` [PATCH 2/2] ntb: " Nicholas Mc Guire
2016-08-22 16:58 ` Jiang, Dave
2016-08-23 16:43 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471884696-25558-1-git-send-email-hofrat@osadl.org \
--to=hofrat@osadl.org \
--cc=Allen.Hubbe@emc.com \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®