From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933125AbcHVQte (ORCPT ); Mon, 22 Aug 2016 12:49:34 -0400 Received: from www.osadl.org ([62.245.132.105]:37320 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933033AbcHVQtc (ORCPT ); Mon, 22 Aug 2016 12:49:32 -0400 From: Nicholas Mc Guire To: Jon Mason Cc: Dave Jiang , Allen Hubbe , Logan Gunthorpe , Arnd Bergmann , Sudip Mukherjee , linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH 2/2] ntb: make DMA_OUT_RESOURCE_TO HZ independent Date: Mon, 22 Aug 2016 18:51:36 +0200 Message-Id: <1471884696-25558-2-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1471884696-25558-1-git-send-email-hofrat@osadl.org> References: <1471884696-25558-1-git-send-email-hofrat@osadl.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org schedule_timeout_* takes a timeout in jiffies but the code currently is passing in a constant which makes this timeout HZ dependent, so pass it through msecs_to_jiffies() to fix this up. Signed-off-by: Nicholas Mc Guire --- Problem found by coccinelle script The below patch sets the timeout to 50ms - not clear what HZ setting was assumed during design/testing, so this needs an ack by someone who knows the driver and can confirm that 50ms is reasonable to wait on DMA retries. Patch was compile tested with: x86_64_defconfig + CONFIG_NTB=m, CONFIG_NTB_PERF=m Patch is against 4.8.0-rc2 (localversion-next is -next-20160822) drivers/ntb/test/ntb_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 6a50f20..e065b69 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -72,7 +72,7 @@ #define MAX_THREADS 32 #define MAX_TEST_SIZE SZ_1M #define MAX_SRCS 32 -#define DMA_OUT_RESOURCE_TO 50 +#define DMA_OUT_RESOURCE_TO msecs_to_jiffies(50) #define DMA_RETRIES 20 #define SZ_4G (1ULL << 32) #define MAX_SEG_ORDER 20 /* no larger than 1M for kmalloc buffer */ -- 2.1.4