From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756192AbcHVRqj (ORCPT ); Mon, 22 Aug 2016 13:46:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:46117 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755544AbcHVRqh (ORCPT ); Mon, 22 Aug 2016 13:46:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,561,1464678000"; d="scan'208";a="615494" From: Andi Kleen To: luto@kernel.org Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH] Disable warning for leaked single step handling Date: Mon, 22 Aug 2016 10:46:28 -0700 Message-Id: <1471887988-10770-1-git-send-email-andi@firstfloor.org> X-Mailer: git-send-email 2.5.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen When running the x86 selftests in qemu TCG the leaked single step warning in traps.c triggers. It's probably an qemu emulation bug, but for now it means this code needs to be kept and the warning removed. Signed-off-by: Andi Kleen --- arch/x86/kernel/traps.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index b70ca12dd389..ad999b550ba2 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -693,12 +693,10 @@ dotraplinkage void do_debug(struct pt_regs *regs, long error_code) goto exit; } - if (WARN_ON_ONCE((dr6 & DR_STEP) && !user_mode(regs))) { + if ((dr6 & DR_STEP) && !user_mode(regs)) { /* * Historical junk that used to handle SYSENTER single-stepping. - * This should be unreachable now. If we survive for a while - * without anyone hitting this warning, we'll turn this into - * an oops. + * Still needed on qemu TCG. */ tsk->thread.debugreg6 &= ~DR_STEP; set_tsk_thread_flag(tsk, TIF_SINGLESTEP); -- 2.5.5