From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754811AbcHWQoS (ORCPT ); Tue, 23 Aug 2016 12:44:18 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:56846 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752931AbcHWQoQ (ORCPT ); Tue, 23 Aug 2016 12:44:16 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com u7NGhFSY012526 X-Nifty-SrcIP: [119.242.215.193] From: Masahiro Yamada To: Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Patrik Jakobsson , David Airlie , Andrew Morton , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] drm/gma500: remove unnecessary config_enabled() guard Date: Wed, 24 Aug 2016 01:42:54 +0900 Message-Id: <1471970574-23906-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit d112a8163f83 ("gma500/cdv: Add eDP support") replaced the code inside this if-conditional with gma_backlight_set(), which becomes a nop stub if CONFIG_BACKLIGHT_CLASS_DEVICE is disabled. So, there is no need to guard the caller with config_enabled(). Note: This is one of remaining TODOs to deprecate config_enabled() macro. Refer to commit 97f2645f358b ("tree-wide: replace config_enabled() with IS_ENABLED()"). Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/gma500/opregion.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/opregion.c b/drivers/gpu/drm/gma500/opregion.c index ab696ca..eab6d88 100644 --- a/drivers/gpu/drm/gma500/opregion.c +++ b/drivers/gpu/drm/gma500/opregion.c @@ -163,10 +163,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) if (bclp > 255) return ASLE_BACKLIGHT_FAILED; - if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) { - int max = bd->props.max_brightness; - gma_backlight_set(dev, bclp * max / 255); - } + gma_backlight_set(dev, bclp * bd->props.max_brightness / 255); asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID; -- 1.9.1