From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932926AbcHXKwU (ORCPT ); Wed, 24 Aug 2016 06:52:20 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:51499 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302AbcHXKwS (ORCPT ); Wed, 24 Aug 2016 06:52:18 -0400 From: John Garry To: , CC: , , , , , , John Garry Subject: [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached Date: Wed, 24 Aug 2016 19:05:52 +0800 Message-ID: <1472036754-156813-7-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1472036754-156813-1-git-send-email-john.garry@huawei.com> References: <1472036754-156813-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0201.57BD7B69.006C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4a91e40bd80ad2e30e33ac7bca18e6a3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the port is detached we cannot execute a TMF, as there can be no device attached to the port. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 280a19d..73f581f 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -204,7 +204,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba, return rc; } port = device->port->lldd_port; - if (port && !port->port_attached && !tmf) { + if (port && !port->port_attached) { if (sas_protocol_ata(task->task_proto)) { struct task_status_struct *ts = &task->task_status; -- 1.9.1