From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753624AbcHXM2o (ORCPT ); Wed, 24 Aug 2016 08:28:44 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:42841 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbcHXM2m (ORCPT ); Wed, 24 Aug 2016 08:28:42 -0400 Message-ID: <1472041622.5335.32.camel@pengutronix.de> Subject: Re: [PATCH 2/2] reset: uniphier: use of_device_get_match_data() to get matched data From: Philipp Zabel To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 24 Aug 2016 14:27:02 +0200 In-Reply-To: <1472020830-16059-3-git-send-email-yamada.masahiro@socionext.com> References: <1472020830-16059-1-git-send-email-yamada.masahiro@socionext.com> <1472020830-16059-3-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, Am Mittwoch, den 24.08.2016, 15:40 +0900 schrieb Masahiro Yamada: > Use of_device_get_match_data() instead of of_match_node(). With > this, we can retrieve the .data field of the OF match table more > easily. No more need to define (or declare) the match table before > the probe callback. I prefer to collect boilerplates at the bottom > of the file, so moved it below. > > Signed-off-by: Masahiro Yamada > --- > > drivers/reset/reset-uniphier.c | 81 +++++++++++++++++++++--------------------- > 1 file changed, 40 insertions(+), 41 deletions(-) > > diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c > index 41c62af..9b3f2cd 100644 > --- a/drivers/reset/reset-uniphier.c > +++ b/drivers/reset/reset-uniphier.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -285,6 +286,45 @@ static const struct reset_control_ops uniphier_reset_ops = { > .status = uniphier_reset_status, > }; > > +static int uniphier_reset_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct uniphier_reset_priv *priv; > + const struct uniphier_reset_data *p, *data; > + struct regmap *regmap; > + struct device_node *parent; > + unsigned int nr_resets = 0; > + > + data = of_device_get_match_data(dev); > + WARN_ON(!data); I know right now this can't happen anyway, but you did return -EINVAL here before. Maybe use: if (WARN_ON(!data)) return -EINVAL; instead? I can fix it up if you agree. > + parent = of_get_parent(dev->of_node); /* parent should be syscon node */ > + regmap = syscon_node_to_regmap(parent); > + of_node_put(parent); > + if (IS_ERR(regmap)) { > + dev_err(dev, "failed to get regmap (error %ld)\n", > + PTR_ERR(regmap)); > + return PTR_ERR(regmap); > + } > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + for (p = data; p->id != UNIPHIER_RESET_ID_END; p++) If in the future somebody forgets to set OF match data, this would be a NULL pointer dereference. regards Philipp