From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: mpm@selenic.com, herbert@gondor.apana.org.au,
linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, LABBE Corentin <clabbe.montjoie@gmail.com>
Subject: [PATCH v3 5/8] hwrng: amd: release_region must be called after hwrng_unregister
Date: Fri, 26 Aug 2016 13:11:33 +0200 [thread overview]
Message-ID: <1472209896-17197-6-git-send-email-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <1472209896-17197-1-git-send-email-clabbe.montjoie@gmail.com>
The driver release the memory region before being sure that nobody use
it.
This patch made hwrng_unregister ran before any release was done.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/char/hw_random/amd-rng.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c
index de82fe3..383e197 100644
--- a/drivers/char/hw_random/amd-rng.c
+++ b/drivers/char/hw_random/amd-rng.c
@@ -151,8 +151,9 @@ static void __exit mod_exit(void)
{
u32 pmbase = (unsigned long)amd_rng.priv;
- release_region(pmbase + 0xF0, 8);
hwrng_unregister(&amd_rng);
+
+ release_region(pmbase + 0xF0, 8);
}
module_init(mod_init);
--
2.7.3
next prev parent reply other threads:[~2016-08-26 11:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 11:11 [PATCH v3 0/8] hwrng: amd: rework of the amd hwrng driver LABBE Corentin
2016-08-26 11:11 ` [PATCH v3 1/8] hwrng: amd: Fix style problem with blank line LABBE Corentin
2016-08-26 11:11 ` [PATCH v3 2/8] hwrng: amd: use the BIT macro LABBE Corentin
2016-08-26 11:11 ` [PATCH v3 3/8] hwrng: amd: Be consitent with the driver name LABBE Corentin
2016-08-26 11:11 ` [PATCH v3 4/8] hwrng: amd: Remove asm/io.h LABBE Corentin
2016-08-26 11:11 ` LABBE Corentin [this message]
2016-08-26 11:11 ` [PATCH v3 6/8] hwrng: amd: Replace global variable with private struct LABBE Corentin
2016-08-27 14:43 ` Jason Cooper
2016-08-27 15:36 ` Jason Cooper
2016-08-26 11:11 ` [PATCH v3 7/8] hwrng: amd: Access hardware via ioread32/iowrite32 LABBE Corentin
2016-08-26 11:11 ` [PATCH v3 8/8] hwrng: amd: Convert to new hwrng read() API LABBE Corentin
2016-08-27 14:49 ` [PATCH v3 0/8] hwrng: amd: rework of the amd hwrng driver Jason Cooper
2016-08-31 15:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472209896-17197-6-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®