mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sumit Gupta <sumitg@nvidia.com>
To: <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>
Cc: <bbasu@nvidia.com>, <linux-tegra@vger.kernel.org>,
	<sudeep.holla@arm.com>, Sumit Gupta <sumitg@nvidia.com>
Subject: [PATCH ] drivers/base: cacheinfo: remove warning in resume
Date: Mon, 29 Aug 2016 12:50:54 +0530	[thread overview]
Message-ID: <1472455254-27692-1-git-send-email-sumitg@nvidia.com> (raw)

CPU notifier is present for creating device
entries for child node "cache" under parent
node "cpu" as per DT. During resume from
suspend, while booting all non-boot CPU's,
this notifier for adding cache device gets
called before cpu device is added by
device_resume. Because of this warning message
of "parent should not be sleeping" comes during
resume.

Removing the notifier to explicitly add/remove
cache device as CPU and cache device get
added/removed anyway as part of normal suspend
resume sequence.
dpm_resume_end - > dpm_resume -> device_resume

Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
---
 drivers/base/cacheinfo.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
index e9fd32e91668..17d9c051a16f 100644
--- a/drivers/base/cacheinfo.c
+++ b/drivers/base/cacheinfo.c
@@ -544,8 +544,6 @@ static int __init cacheinfo_sysfs_init(void)
 			goto out;
 		}
 	}
-	__hotcpu_notifier(cacheinfo_cpu_callback, 0);
-
 out:
 	cpu_notifier_register_done();
 	return rc;
-- 
2.1.4

             reply	other threads:[~2016-08-29  7:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29  7:20 Sumit Gupta [this message]
2016-08-30 10:20 ` Sudeep Holla
2016-09-02 12:58   ` Sumit Gupta
2016-09-02 15:02     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472455254-27692-1-git-send-email-sumitg@nvidia.com \
    --to=sumitg@nvidia.com \
    --cc=bbasu@nvidia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome